D10429: Disable the title bar separator by default

IlyaBizyaev added a comment. I think this line's goal is not really to separate the title bar from window content, but instead to make the transition smoother and emphasize style consistency. Take a look at these 2 screenshots, for example. F6267692: Screenshot_20180916_124803.png

D10429: Disable the title bar separator by default

IlyaBizyaev added a comment. I'll be that one person here who likes the separator and notices it easily on the Breeze theme. I have no objections to changing the default, but "just removing it entirely" is not an option. REPOSITORY R31 Breeze REVISION DETAIL

D10429: Disable the title bar separator by default

This revision was automatically updated to reflect the committed changes. Closed by commit R31:51cedac0889b: Disable the title bar separator by default (authored by fvogt). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10429?vs=26883=41512 REVISION DETAIL

D10429: Disable the title bar separator by default

ngraham added a comment. In D10429#324936 , @romangg wrote: > It's unnecessary bling imo. And it can interfere with in-window elements (Firefox for example marks the active tab with a very similar colored line at the top). I would say let's try

D10429: Disable the title bar separator by default

romangg accepted this revision. romangg added a comment. It's unnecessary bling imo. And it can interfere with in-window elements (Firefox for example marks the active tab with a very similar colored line at the top). I would say let's try it out and listen for feedback in 5.14 cycle if

D10429: Disable the title bar separator by default

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think all the +1s here deserve to amount to at least one green checkbox. :) REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt,

D10429: Disable the title bar separator by default

ngraham added a comment. +1 for tri-state as a compromise, but I still don't really see the point, as in Breeze light it's almost invisible even when on. Would also approve of off-by-default or even removing it entirely. REPOSITORY R31 Breeze REVISION DETAIL

D10429: Disable the title bar separator by default

mart added a comment. shouldn't make it worse for everybody to make it better for the subset who use a dark theme. at most, should be if the palette color is darker than something, draw it, otherwise don't so +1 for 3state REPOSITORY R31 Breeze REVISION DETAIL

D10429: Disable the title bar separator by default

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10429: Disable the title bar separator by default

rizzitello added a comment. I'm a breeze dark user and the current color is just way to strong on this theme as @ngraham said above. It was quite jarring to have this bright line on my window out of nowhere. If we can not find a more muted color then my vote its +1 disable no need to

D10429: Disable the title bar separator by default

mmustac added a comment. In D10429#204760 , @broulik wrote: > Can't we make it a tri-state thing? Always on, heuristic (default, like we used to have), disabled? Like that idea. REPOSITORY R31 Breeze REVISION DETAIL

D10429: Disable the title bar separator by default

broulik added a comment. Can't we make it a tri-state thing? Always on, heuristic (default, like we used to have), disabled? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: broulik, anthonyfieroni, januz, rikmills, anemeth,

D10429: Disable the title bar separator by default

anthonyfieroni added a comment. -1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10429: Disable the title bar separator by default

januz added a comment. I can't +1 this hard enough. There's no point in having a line separating the titlebar from the window. For users that want their titlebars the same color as the window it just gets in the way, and for users that want a clear separation it adds nothing (since there's

D10429: Disable the title bar separator by default

rikmills added a comment. +1 for turning off by default or removing altogether. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10429: Disable the title bar separator by default

ngraham added a comment. If we turn it off by default, the set of people who will deliberately go and turn it on will be so small that it might make more sense to just remove it entirely. The only people who seem to notice and/of care seem to be people using Breeze Dark or another

D10429: Disable the title bar separator by default

anemeth added a comment. Strawpoll linked from this reddit post : http://www.strawpoll.me/15036330/r Looks like the majority does not like the separator. REPOSITORY R31 Breeze REVISION

D10429: Disable the title bar separator by default

fvogt created this revision. fvogt added reviewers: VDG, Plasma, ngraham. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Since the removal of the heuristics this seems to be very much disliked by many. As there is now a configuration