D10438: reserve space for checkable widgets in menu items

hpereiradacosta added a comment. In D10438#205519 , @zzag wrote: > Maybe an option like "Reserve space for check boxes" should be added in fine tuning settings? Please no option. If we put an option to every feature we are not sure

D10438: reserve space for checkable widgets in menu items

zzag added a comment. Alright here's a patch which would make possible to turn off reserving space. Yet, a checkbox should be added in "Fine tuning" tab. From 45be224b2fb31966a3117aa1f226f8ea711f8109 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Tue,

D10438: reserve space for checkable widgets in menu items

mmustac added a comment. I am a user :-D To be honest I liked Vlad`s proposal after my first comment a lot. { margin-left: 10px; } The current implementation is nothing I would really like to have and be definitly a reason to search for a solution or another theme (which would propably

D10438: reserve space for checkable widgets in menu items

zzag added a comment. Maybe an option like "Reserve space for check boxes" should be added in fine tuning settings? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: alake, colomar, januz, fabianr, mmustac,

D10438: reserve space for checkable widgets in menu items

hpereiradacosta added a comment. In D10438#205505 , @ngraham wrote: > FWIW I like it, but since this is mostly subjective, I wouldn't fight to the death to retain if if everyone else suddenly hated it. ok. Maybe it is just a question to

D10438: reserve space for checkable widgets in menu items

ngraham added a comment. FWIW I like it, but since this is mostly subjective, I wouldn't fight to the death to retain if if everyone else suddenly hated it. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc:

D10438: reserve space for checkable widgets in menu items

hpereiradacosta added subscribers: colomar, alake. hpereiradacosta added a comment. So ... I applied the patch (which I approved), used it, and ... don't like it sorry. See attached screenshots I think the unnecessary space breaks alignment with the menu above. and is completely

D10438: reserve space for checkable widgets in menu items

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8989f8fd9c2c: reserve space for checkable widgets in menu items (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10438?vs=27019=27055 REVISION

D10438: reserve space for checkable widgets in menu items

zzag added a comment. > Not that I know. Also: I cannot reproduce. Here, if I uncheck "Show Icons in Menus" in system settings->widget style->Fine tuning, icons dissapear and shortcut are still there. Seems like it's only relevant to Arch Linux and Arch Linux-based distros. KDE neon

D10438: reserve space for checkable widgets in menu items

fabianr added a comment. @zzag It would be greate if you could add a screenshot of the new context menu to https://community.kde.org/KDE_Visual_Design_Group/HIG/ContextMenu#Examples . Of cause other improvements/corrections to the page are more then welcome, too. If you hagve question you

D10438: reserve space for checkable widgets in menu items

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. In D10438#205230 , @zzag wrote: > > I'm not sure whether these changes should come with this diff or maybe I

D10438: reserve space for checkable widgets in menu items

zzag added a comment. @anemeth here are menu items with centered check boxes and radio buttons: F5708483: aligned-1.png F5708505: aligned-2.png F5708523: aligned-4.png

D10438: reserve space for checkable widgets in menu items

zzag added a comment. In D10438#205139 , @anemeth wrote: > Maybe you could align the checkbox better? > The numbers are pixels > F5708060: a.png I don't really think this diff

D10438: reserve space for checkable widgets in menu items

anemeth added a comment. Maybe you could align the checkbox better? The numbers are pixels F5708060: a.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta

D10438: reserve space for checkable widgets in menu items

zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10438: reserve space for checkable widgets in menu items

ngraham added a comment. +1 on this new approach. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10438: reserve space for checkable widgets in menu items

zzag added a comment. In D10438#205125 , @anemeth wrote: > Whoops, I misunderstood your prev comment. I've deleted changes in breeze.h and breezestyle.h on purpose. REPOSITORY R31 Breeze REVISION DETAIL

D10438: reserve space for checkable widgets in menu items

anemeth added a comment. In D10438#205119 , @zzag wrote: > In D10438#205118 , @anemeth wrote: > > > @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) > > > Yes.

D10438: reserve space for checkable widgets in menu items

zzag added a comment. In D10438#205118 , @anemeth wrote: > @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) Yes. There is no point to keep them. REPOSITORY R31 Breeze REVISION DETAIL

D10438: reserve space for checkable widgets in menu items

zzag retitled this revision from "increase left/right margin of menuitems" to "reserve space for checkable widgets in menu items". zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham,