kossebau added a comment.
Could not reproduce that error locally, and build.kde.org had also not
reported any problems. But given it failed for at least two people and the neon
CI
(https://build.neon.kde.org/job/xenial_unstable_plasma_plasma-desktop_bin_amd64/528/consoleFull)
there might be
bshah added a comment.
Unfortunately we will have to revert this it seems,
CMakeFiles/kcm_lookandfeel.dir/kcm.cpp.o: In function
`KCMLookandFeelFactory::KCMLookandFeelFactory()':
kcm.cpp:(.text+0x2b): undefined reference to `vtable for
KCMLookandFeelFactory'
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:502e8dc1080f: [lookandfeel kcm] Do not declare plugin in
lookandfeeltool code version (authored by kossebau).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Thanks!
please close 389982
REPOSITORY
R119 Plasma Desktop
BRANCH
definenopluginwithlookandfeeltool
REVISION DETAIL
https://phabricator.kde.org/D10485
To: kosse
kossebau added a reviewer: mart.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10485
To: kossebau, #freebsd, tcberner, bshah, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kossebau created this revision.
kossebau added reviewers: FreeBSD, tcberner, bshah.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Also improves race condition on creating the J
