aacid closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10498
To: aacid, davidedmundson, xuetianweng
Cc: knambiar, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
knambiar added a comment.
+1.
I've also spent some time debugging this issue, and was perplexed why the
property change event doesn't propagate. This fix should be backported if
possible.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D10498
REVISION DETAIL
https://phabricator.kde.
aacid added a comment.
I updated the comment, can you have a look and approve again?
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D10498
REVISION DETAIL
https://phabricator.kde.org/D10498
To: aacid, davidedmundson, xuetianweng
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo
xuetianweng accepted this revision.
xuetianweng added a comment.
I sent the comment before you corrected the diff branch. LGTM.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D10498
REVISION DETAIL
https://phabricator.kde.org/D10498
To: aacid, davidedmundson, xuetianweng
Cc: plasma-de
aacid updated this revision to Diff 27126.
aacid added a comment.
better? explanation of why the workaround works
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10498?vs=27125&id=27126
BRANCH
arcpatch-D10498
REVISION DETAIL
https://phabricator.
xuetianweng accepted this revision.
xuetianweng added a comment.
This revision is now accepted and ready to land.
Oh, ok.. now the diff looks normal.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D10498
REVISION DETAIL
https://phabricator.kde.org/D10498
To: aacid, davidedmundson, xue
xuetianweng added a comment.
Emm, mind to get rid of the .desktop part for this review?
Also I think you need to give some explanation about why this works.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10498
To: aacid, davidedmundson, xuetianweng
Cc: p
aacid updated this revision to Diff 27125.
aacid added a comment.
correct diff against Plasma/5.12
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10498?vs=27123&id=27125
BRANCH
arcpatch-D10498
REVISION DETAIL
https://phabricator.kde.org/D10498
aacid updated this revision to Diff 27123.
aacid edited the summary of this revision.
aacid added a comment.
[try to] add BUGS:
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10498?vs=27122&id=27123
BRANCH
arcpatch-D10498
REVISION DETAIL
https:
aacid added reviewers: davidedmundson, xuetianweng.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10498
To: aacid, davidedmundson, xuetianweng
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
aacid created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aacid requested review of this revision.
TEST PLAN
Without it the touchpad toggle at my laptop just toggles once
now it works fine all the time
REPOSITORY
R1
11 matches
Mail list logo