D10500: Make the review pop-up a bit more user-friendly

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d69abdbe4dce: Make the review pop-up a bit more user-friendly (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10500: Make the review pop-up a bit more user-friendly

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH review-popup-button-text REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store, apol, abetts Cc: anemeth, plasma-devel, ZrenBot,

D10500: Make the review pop-up a bit more user-friendly

ngraham added a comment. That's a good idea, but I'm having a bit of trouble with the implementation. If this is otherwise okay, can we land it in its current state, and commit to doing that in a subsequent patch? REPOSITORY R134 Discover Software Store REVISION DETAIL

D10500: Make the review pop-up a bit more user-friendly

abetts added a comment. Looks good to me. I would change the hover animation. Most places that use star ratings tend to highlight all stars up to where your cursor is located. It gives the impression that you are also enabling the starts up to your location. If your cursor is in the fourth

D10500: Make the review pop-up a bit more user-friendly

ngraham added reviewers: apol, abetts. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store, apol, abetts Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10500: Make the review pop-up a bit more user-friendly

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10500: Make the review pop-up a bit more user-friendly

ngraham updated this revision to Diff 27203. ngraham added a comment. - Merge branch 'master' into review-popup-button-text - Also fix 390426 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10500?vs=27131=27203 BRANCH

D10500: Make the review pop-up a bit more user-friendly

ngraham planned changes to this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

ngraham added a comment. The empty space on the bottom is a bug in Kirigami that I fixed this morning with D10502: Eliminate unnecessary bottom padding on OverlaySheets . The star rating change is a good idea (because yeah, 1 star as the default is

D10500: Make the review pop-up a bit more user-friendly

anemeth added a comment. What purpose does the empty space serve? If it has no purpose then the Review textbox could be larger or the window smaller. F5711965: review,_empty.png REPOSITORY R134 Discover Software Store REVISION DETAIL

D10500: Make the review pop-up a bit more user-friendly

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10500: Make the review pop-up a bit more user-friendly

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Polish the design of the review input pop-up,