D10659: [AppletConfiguration] Let applet override Return closing the dialog

mart added a comment. to me is fine.. already the main item can implement functions that can do $stuff, which is not abvious and could be bertter. i guess the best thing is to put a big text comment here what are the supported comments/functions REPOSITORY R119 Plasma Desktop

D10659: [AppletConfiguration] Let applet override Return closing the dialog

kossebau added a subscriber: mart. kossebau added a comment. In D10659#209961 , @broulik wrote: > > Can this property become something more official, with real documentation > > Sure. If you tell me where the other features of the config

D10659: [AppletConfiguration] Let applet override Return closing the dialog

broulik added a comment. > Can this property become something more official, with real documentation Sure. If you tell me where the other features of the config dialog (e.g. the `saveConfig()` function ) is documented, I'd happily add it there. REPOSITORY R119 Plasma Desktop REVISION

D10659: [AppletConfiguration] Let applet override Return closing the dialog

kossebau added a comment. Eek. Undocumented secret properties make my toe nails roll up. Can this property become something more official, with real documentation (and test case), so that other applet config pages can make use of it as well? No real insight into design of applet

D10659: [AppletConfiguration] Let applet override Return closing the dialog

broulik added a dependent revision: D10660: [Weather applet] Let Return invoke search. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10659 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10659: [AppletConfiguration] Let applet override Return closing the dialog

broulik created this revision. broulik added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In weather applet, pressing Return should invoke the