D10728: Improve multi-desktop folderview behavior

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia updated this revision to Diff 28998. amantia added a comment. Moved to 5.12 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10728?vs=27733=28998 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10728 AFFECTED FILES

D10728: Improve multi-desktop folderview behavior

amantia added a comment. I can't put to 5.12 as it seems https://phabricator.kde.org/D9325 didn't get into the 5.12 branch, and I don't want two versions of this patch. May I cherry-pick that commit to 5.12 and apply this patch? REPOSITORY R119 Plasma Desktop BRANCH master REVISION

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Yes, I will push first to 5.12 both of them REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10728: Improve multi-desktop folderview behavior

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Ok, sounds and looks convincing, thanks! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham,

D10728: Improve multi-desktop folderview behavior

hein added a comment. This should go into 5.12 btw (ditto D10729 ) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D10728: Improve multi-desktop folderview behavior

amantia added a comment. It adds a new entry, doesn't change an existing one. If that is not there, I see no problems, the ScreenMapper::readDisabledScreensMap() will not initialize the m_itemsOnDisabledScreensMap. That map was not saved previously, thus the folderview behaving differently

D10728: Improve multi-desktop folderview behavior

hein added a comment. Since this seems to change the map format, is this safe to upgrade for users with existing config? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added reviewers: Plasma, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL