D10855: Emit clicked when double click expires

romangg added a comment. Why is the press and hold timer still needed? It should be enough to only test on double click expiration with this patch and open the menu on release of mouse button afterwards. We should accept this behavioral change in order to reduce code complexity (people

D10855: Emit clicked when double click expires

broulik added a comment. Ping. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10855 To: broulik, #plasma, graesslin, #vdg Cc: mart, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10855: Emit clicked when double click expires

broulik added a comment. So, what shall we do with this? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10855 To: broulik, #plasma, graesslin, #vdg Cc: mart, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10855: Emit clicked when double click expires

mart added a comment. on the link i see mostly the motivation as a personal opinion of Thomas L. The fact i kinda defend this diff is that the vdg is pushing to limit and drop the long press buttons menus on most places. this is a thing i think should take proper discussion in the vdg and

D10855: Emit clicked when double click expires

graesslin added a comment. I found https://git.reviewboard.kde.org/r/103995/ but it references older changes which I just didn't find with git log. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10855 To: broulik, #plasma, graesslin Cc: mart,

D10855: Emit clicked when double click expires

mart added a comment. In D10855#215256 , @graesslin wrote: > I kindly ask to look at the discussion ack in reviewboard when I implemented this feature. It was one of the most difficult changes to get in and this was the only solution we came

D10855: Emit clicked when double click expires

ngraham added a comment. In D10855#214380 , @ngraham wrote: > Does this result in a behavior change such that a slow user with a mouse who clicks and then leaves the mouse in the same place for a moment will get a context menu? If so, I'm not

D10855: Emit clicked when double click expires

graesslin added a comment. In D10855#214923 , @broulik wrote: > > Given that I'm not sure whether the base assumption that this is not intuitive holds. > > Having to explain to a user what to do hardly qualifies as intuitive. No

D10855: Emit clicked when double click expires

broulik added a comment. > Given that I'm not sure whether the base assumption that this is not intuitive holds. Having to explain to a user what to do hardly qualifies as intuitive. > The behavior by the way was inspired by other components such as toolbar buttons with dropdown

D10855: Emit clicked when double click expires

graesslin added a comment. > Press and hold isn't particularly intuitive. When enabling this behavior (which is default off) a message is shown with the following content: "Close by double clicking:\n To open the menu, keep the button pressed until it appears." Given that I'm not

D10855: Emit clicked when double click expires

ngraham added a comment. Does this result in a behavior change such that a slow user with a mouse who clicks and then leaves the mouse in the same place for a moment will get a context menu? If so, I'm not sure that's a good idea. Lots of users aren't so great with non-touch input devices

D10855: Emit clicked when double click expires

broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Press and hold isn't particularly intuitive. Instead,