This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b3f9cd9092f: [taskmanager applet] Fix MPRIS entries in
context menu for CanPause==false (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D11007?vs=28799=28803#toc
kossebau edited the summary of this revision.
kossebau edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
fixtaskmanagercontextmenuformpris
REVISION DETAIL
https://phabricator.kde.org/D11007
To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai,
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
fixtaskmanagercontextmenuformpris
REVISION DETAIL
https://phabricator.kde.org/D11007
To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
kossebau updated this revision to Diff 28799.
kossebau added a comment.
one var per variable
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11007?vs=28776=28799
BRANCH
fixtaskmanagercontextmenuformpris
REVISION DETAIL
kossebau marked an inline comment as done.
kossebau added inline comments.
INLINE COMMENTS
> broulik wrote in ContextMenu.qml:169
> In the media controller you do status == "playing" || status == "paused"
> whereas here you do status == "stopped"?
Yes, in the media controller the status is
broulik added a comment.
almost good
INLINE COMMENTS
> ContextMenu.qml:122
> +var playing = (playerData.PlaybackStatus === "Playing"),
> +menuItem = menu.newMenuItem(menu);
> menuItem.text = i18nc("Play previous track", "Previous
>
kossebau updated this revision to Diff 28776.
kossebau added a comment.
push missed update without playpause
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11007?vs=28610=28776
BRANCH
fixtaskmanagercontextmenuformpris
REVISION DETAIL
kossebau updated this revision to Diff 28610.
kossebau added a comment.
cache isPlayingCheck in bool, fix icon update of play/pause menu entry
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11007?vs=28529=28610
BRANCH
kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS
controllers.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D11007
To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Also disable "Stop" menu entry if there is nothing to stop
10 matches
Mail list logo
