D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs added a comment. In D11261#224058 , @abetts wrote: > In D11261#224056 , @Fuchs wrote: > > > In D11261#224054 , @abetts wrote: > > > > > We have

D11261: Add a button to clear the notification history

2018-03-12 Thread Andres Betts
abetts added a comment. In D11261#224056 , @Fuchs wrote: > In D11261#224054 , @abetts wrote: > > > We have discussed something like this before. My only worry with this implementation is that we

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs added a comment. In D11261#224054 , @abetts wrote: > We have discussed something like this before. My only worry with this implementation is that we have so much red on the screen that it becomes distracting. Not the fault of this patch,

D11261: Add a button to clear the notification history

2018-03-12 Thread Andres Betts
abetts added a comment. We have discussed something like this before. My only worry with this implementation is that we have so much red on the screen that it becomes distracting. Not the fault of this patch, but I am wondering if there is a way that we can use a monochrome X button?

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs added a comment. New screenshot with fixes F5750621: clearhistory.png REPOSITORY R120 Plasma Workspace BRANCH fuchs-notification-clearhistory (branched from master) REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc:

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29325. Fuchs added a comment. - Better hack for placement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29321=29325 BRANCH fuchs-notification-clearhistory (branched from master) REVISION DETAIL

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29321. Fuchs added a comment. - Change the layout import according to kbroulik REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29320=29321 BRANCH fuchs-notification-clearhistory (branched from master)

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29320. Fuchs added a comment. - Use Math.round() as per discussion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29319=29320 BRANCH fuchs-notification-clearhistory (branched from master) REVISION

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29319. Fuchs added a comment. - Capitalized History in the tooltip label as per discussion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29318=29319 BRANCH fuchs-notification-clearhistory (branched