D11522: [RFC] KCM Launch Feedback not saving cursor settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8af970fd49f3: KCM Launch Feedback not saving cursor settings (authored by sharvey, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey added a comment. In D11522#230474 , @hein wrote: > Nah, it's to prevent an infinite loop between the different radio buttons and the backend object, since onCheckedChange will fire for both false and true. Makes sense, in a QML

D11522: [RFC] KCM Launch Feedback not saving cursor settings

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nah, it's to prevent an infinite loop between the different radio buttons and the backend object, since onCheckedChange will fire for both false and true. Thanks! Should I commit this for

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey updated this revision to Diff 30042. sharvey added a comment. - Revise code to use `Qt.callLater()` instead of invalid `Qt.later()` Per @hein, revised with correct function call REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey added a comment. In D11522#230217 , @hein wrote: > The actuall bug here is pretty stupid - the function is called callLater(), not later(). Could you modify the patch to use callLater? Sure, easy enough. As long as you (or

D11522: [RFC] KCM Launch Feedback not saving cursor settings

hein added a comment. The actuall bug here is pretty stupid - the function is called callLater(), not later(). Could you modify the patch to use callLater? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11522 To: sharvey, #plasma, hein, davidedmundson,

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey marked an inline comment as done. sharvey added a comment. Braces and semicolons removed. Taking these away was one of the ways I'd get a segfault. This time, however, all's well in the world. I need to keep debugging my environment. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey updated this revision to Diff 30031. sharvey edited the summary of this revision. sharvey added a comment. - Removed erroneous braces and semicolons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11522?vs=30028=30031 BRANCH

D11522: [RFC] KCM Launch Feedback not saving cursor settings

ngraham added a comment. Thanks for the patch! Formatting-wise, please capitalize Bug (should be BUG). INLINE COMMENTS > main.qml:63 > > -onCheckedChanged: Qt.later(function() { > kcm.busyCursorCurrentIndex = 0; }) > +onCheckedChanged: {

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY [Bug 392050] Launch Feedback KCM was not saving the cursor notifications properly - `Apply`