volkov abandoned this revision.
volkov added a comment.
Moved to https://invent.kde.org/plasma/breeze/-/merge_requests/7
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D11573
To: volkov, #breeze
Cc: graesslin, davidedmundson, broulik, plasma-devel, Orage, LeGast00n,
graesslin added a comment.
In general I like the idea and that should be extended to Wayland as well,
but private API is a no-no for breeze. That has huge runtime breakage potential.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D11573
To: volkov, #breeze
Cc:
volkov added a comment.
IIRC, the X server floors coordinates, while Qt rounds them.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D11573
To: volkov, #breeze
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
davidedmundson added a comment.
> Note that now globalPos is used when creating QMouseEvent that
> triggers window movement. Otherwise QMouseEvent will take it
> from QCursor::pos() with integer coordinates received from the
> X server, which may differ from coordinates rounded by Qt for
volkov added a comment.
https://codereview.qt-project.org/224251
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D11573
To: volkov, #breeze
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
+++ to using this.
However, I think we should at least try to get this as public API in Qt,
rather than using internals.
Breeze is far from the only case where someone would want to do this and
QWindow has other system calls it seems to make sense to
broulik added inline comments.
INLINE COMMENTS
> breezewindowmanager.cpp:100
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0)
> +#include
> #endif
Using private API will lock Breeze to that specific Qt version it was compiled
with, requiring a rebuild. This has imho shown to be quite painful
volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
volkov requested review of this revision.
REVISION SUMMARY
... instead of X11 API to initiate window movement by a window
manager. It works correctly when
