This revision was automatically updated to reflect the committed changes.
Closed by commit R115:d498ec301bb3: Fix issues in models to pass ModelTest
(authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11721?vs=30639=30640
drosca updated this revision to Diff 30639.
drosca added a comment.
fix issues
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11721?vs=30638=30639
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11721
AFFECTED FILES
drosca added inline comments.
INLINE COMMENTS
> broulik wrote in maps.h:116
> This creates a temporary list just to iterate it, better use iterators and
> then `key()` provided by it (I bet there's even a fancy `std` algorithm for
> what you're trying to do here)
Some fancy `std` algorithm
davidedmundson added a comment.
Other than Kai's coments, ++ good stuff. thanks
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D11721
To: drosca, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai,
ali-mohamed,
broulik added inline comments.
INLINE COMMENTS
> maps.h:116
> +int modelIndex = 0;
> +const auto keys = m_data.keys();
> +for (quint32 key : keys) {
This creates a temporary list just to iterate it, better use iterators and then
`key()` provided by it (I bet there's
drosca updated this revision to Diff 30638.
drosca added a comment.
whitespace
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11721?vs=30637=30638
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11721
AFFECTED FILES
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
drosca requested review of this revision.
TEST PLAN
Did all sort of things with pulseaudio and all ModelTest tests passed.
