D12256: [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:ad50781ec718: [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12256?vs=32324=35764

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. KF 5.47 will be released soon enough so I guess that's OK to ship the code as is. Am I right? REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To:

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. @broulik Ping. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To: zzag, #breeze, hpereiradacosta Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. In D12256#248144 , @broulik wrote: > This is master-only code, right? Yes, it's master-only. > The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine. So, given that, should I bump version

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

broulik added a comment. This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To: zzag, #breeze, hpereiradacosta Cc:

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added subscribers: ngraham, broulik, davidedmundson. zzag added a comment. @davidedmundson @broulik @ngraham Do you have any objections to bumping minimum required version of KF5FrameworkIntegration? //We need at least KF 5.45 so KCapacityBar and co have

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. In D12256#247950 , @ltoscano wrote: > Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)? Is

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

ltoscano added a comment. Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)? REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To: zzag, #breeze, hpereiradacosta Cc:

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY D11566 is now in KDE