This revision was automatically updated to reflect the committed changes.
Closed by commit R123:ebdfab7e0867: Read theme.conf of themes (authored by
fvogt).
REPOSITORY
R123 SDDM Configuration Panel (KCM)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12323?vs=32499=32549
REVISION
fvogt added inline comments.
INLINE COMMENTS
> davidedmundson wrote in themeconfig.cpp:169
> nice solution
>
> "NoGlobals" - Cascade to system settings, but omit user's globals.
>
> should work better. It will include the added sources, but no more
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
1 minor change.
INLINE COMMENTS
> themeconfig.cpp:169
> if (configFile.exists()) {
> -KSharedConfigPtr themeConfig =
>
fvogt added a comment.
(Actually targeting the Plasma/5.12 branch)
REPOSITORY
R123 SDDM Configuration Panel (KCM)
REVISION DETAIL
https://phabricator.kde.org/D12323
To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.
REVISION SUMMARY
Otherwise kcm_sddm ignores values in there. Previously, a theme with a default
background image reverts to a color background
