D12373: Klipper: Remove first history item on clipboard clear

ngraham added a comment. If this is obsolete now, you can choose "Abandon revision" from the {nav Add Action..." dropdown menu button that's above the comment box. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12373 To: hoffmannrobert Cc: ngraham,

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. Thank you, that caused the issue. Now it works well with keepassx. That's a much better solution, than removing from history. I've create a new revision for it: https://phabricator.kde.org/D12539 REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12373: Klipper: Remove first history item on clipboard clear

davidedmundson added a comment. Thanks for following this up! In keepassx you need a second QMimeData void QClipboard::setMimeData(QMimeData *src, Mode mode = Clipboard) Sets the clipboard data to src. Ownership of the data is transferred to the clipboard. So the second

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. In D12373#253569 , @davidedmundson wrote: > mimeData is key value pairs, you can have many pieces of mimeData. > > So we have text/plain with the password as before > and x-kde-passwordManagerHint

D12373: Klipper: Remove first history item on clipboard clear

davidedmundson added a comment. > Storing such a 'text/confidential' string in the clipboard with mode 'QClipboard::Clipboard' works, and Klipper could handle it by not storing it in its history. But unfortunately the clipboard contents are of no use to any application. They check the

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert updated this revision to Diff 33060. hoffmannrobert added a comment. Klipper: Fix option RemoveTopHistoryItemOnClear REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12373?vs=32630=33060 BRANCH master REVISION DETAIL

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. Some facts: - The clipboard in KDE is a QClipboard instance. - Klipper is a frontend to the clipboard with a history. It exchanges data with the QClipboard instance. - QClipboard provides the facility of setting mime types with data it stores. All

D12373: Klipper: Remove first history item on clipboard clear

graesslin added a comment. Sorry, but I'm against this. The options keepass provides are just bullshit (sorry to be that direct). That cannot work and will not work. One cannot remove anything from the clipboard, trying to do so is insane. What would make most sense for things like

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. You are right, the "prevent empty clipboard" option needs to be set to false to make the "RemoveTopHistoryItemOnClear" option work correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12373 To: hoffmannrobert Cc:

D12373: Klipper: Remove first history item on clipboard clear

davidedmundson added a comment. We have two settings: The first, when the X selection owner gets cleared, replaces the clipboard with the top entry This one when the X selection owner gets cleared, deletes the top entry in the UI. Both default to on, which together makes no sense.

D12373: Klipper: Remove first history item on clipboard clear

broulik added a comment. Ideally, there was a mime data flag an application could set to indicate it wouldn't want it to end up in clipboard history but this is probably impossible to get applications to use.. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. In D12373#250306 , @davidedmundson wrote: > Right, but pressing control+v again won't paste the item after clearing which I assumed was the intended goal Yes, pressing Control+V won't paste the item after

D12373: Klipper: Remove first history item on clipboard clear

davidedmundson added a comment. Right, but pressing control+v again won't paste the item after clearing which I assumed was the intended goal REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12373 To: hoffmannrobert Cc: davidedmundson, plasma-devel,

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. In D12373#250303 , @davidedmundson wrote: > Aren't you just duplicating the existing "prevent empty clipboard" option ? No, the "prevent empty clipboard" option ensures that the clipboard doesn't stay

D12373: Klipper: Remove first history item on clipboard clear

davidedmundson added a comment. Aren't you just duplicating the existing "prevent empty clipboard" option ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12373 To: hoffmannrobert Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Password manager tools like Keepassx offer an option to clear the