D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. I just tried that here and it works fine (Qt 5.15.1). Maybe there's something else in the environment which breaks it? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: memeplex, anthonyfieroni, luxus, snugghash,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

memeplex added a comment. > It should work. Are you sure the screen names are correct and match? You can run `QT_LOGGING_RULES=qt.qpa.screen.debug=true konsole` to get the ones `konsole` itself sees. The names are correct, otherwise I guess it wouldn't have worked in any case.

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. In D12405#676733 , @memeplex wrote: > So I set QT_SCREEN_SCALE_FACTORS='eDP-1=2;DP-2=1.7;'. But consider: > > 1. QT_AUTO_SCREEN_SCALE_FACTOR=1 QT_SCREEN_SCALE_FACTORS='eDP-1=2;DP-2=1.7;' konsole > 2.

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

memeplex added a comment. I'm not testing the proposed patch per se, but if it's only about setting QT_SCREEN_SCALE_FACTORS it doesn't work for me as I would have expected. I have two screens, my laptop requires 2x scale, the external monitor requires about 1.7x. So I set

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

anthonyfieroni added a comment. I test, current situation, i don't think the parch is needed as is. 2 monitors FullHD and 4K (HDMI) now KScreen does not allow different scale factor, to distinct monitor but you can changed config [KScreen] ScaleFactor=1

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

ngraham added a comment. Plasma now depends on Qt 5.14. Is there anything in there that would allow this to move forward? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: luxus, snugghash, gladhorn, mart, hein, ngraham, graesslin,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. There's some new env vars in Qt 5.14 to set a policy of what to do with DPI. Might be useful. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: snugghash, gladhorn, mart, hein, ngraham, graesslin,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

ngraham added a comment. Ok, thanks for the info. I'll excuse myself now since the technical discussion is way over my head. I just wanted to express support for the idea behind this patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. The negative aspects of this patch are not related to whether Wayland exists. The negative aspects are that we have ui options that only affect a subset of applications, and merging this will make merging the patch to make plasma use Qt scaling a /lot/

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

ngraham added a comment. We're past 5.14 and into 5.15 territory now. Does this deserve another look? My personal opinion is that it's not wise to under-invest in the X11 code while Wayland is still very much a work in progress. I get that it's frustrating to work on code that you know

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added inline comments. INLINE COMMENTS > gladhorn wrote in outputconfig.cpp:145 > Why not use QScopedPointer here? I just moved the code from kcm/src/widget.cpp. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: gladhorn, mart, hein,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

gladhorn added inline comments. INLINE COMMENTS > outputconfig.cpp:145 > +connect(scaleDialogButton, ::released, [this] { > +QPointer dialog = new ScalingConfig(mOutput, > this); > +dialog->exec(); Why not use QScopedPointer here? REPOSITORY R104 KScreen

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

gladhorn added a comment. I've been running with QT_SCREEN_SCALE_FACTORS set manually for at least half a year and it works for me. Except for suspending, so that seems to be a wide spread issue, maybe even in Qt. I'm strongly in favor of this, it is the only thing that works sensibly on

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. In D12405#257444 , @davidedmundson wrote: > The good: > > In one setup I was pleasantly surpised at how well it worked. Fonts did behave as expected. > Specatcle was able to capture all screens and individual

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. The good: In one setup I was pleasantly surpised at how well it worked. Fonts did behave as expected. Specatcle was able to capture all screens and individual rects correctly. The less good: When I switched round the primary monitor all

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt updated this revision to Diff 33520. fvogt added a comment. Fix build REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12405?vs=32709=33520 BRANCH perscreenxcb REVISION DETAIL https://phabricator.kde.org/D12405 AFFECTED FILES

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added inline comments. INLINE COMMENTS > outputconfig.cpp:143 > +} else { > +QPushButton scaleDialogButton = new QPushButton(i18n("Scale > Display"), this); > +connect(scaleDialogButton, ::released, [this] { QPushButton* REPOSITORY R104 KScreen REVISION

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > As for this patch. It needs Qt patches, so it's definitely not 5.13, possibly not even 5.14 material. > > After 5.13.0 I'm willing to give this a fair test. > If it indeed does work great, cool. That's a misunderstanding. The code here as-is works with Qt

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. As for this patch. It needs Qt patches, so it's definitely not 5.13, possibly not even 5.14 material. After 5.13.0 I'm willing to give this a fair test. If it indeed does work great, cool. However, I dont' want to merge something that replaces one

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > It is, for things that aren't Qt Yup. Just for Qt it's not required anymore. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: mart, hein, ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. > With https://bugreports.qt.io/browse/QTBUG-67928 fixed, the Xft.dpi setting code shouldn't be needed anymore either. It is, for things that aren't Qt REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc:

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > -1 from here as well, it won't and it can't work reliably, it would be pretty much a false promise It does though. With https://bugreports.qt.io/browse/QTBUG-67928 fixed, the Xft.dpi setting code shouldn't be needed anymore either. REPOSITORY R104

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

mart added a comment. -1 from here as well, it won't and it can't work reliably, it would be pretty much a false promise REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: mart, hein, ngraham, graesslin, davidedmundson, plasma-devel,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

hein added a comment. In principle I'm inclined to side with Martin here. At this point, I no longer want the extra burden/distraction of working on newly-introduced X11-related bugs. It's frustrating to spend manhours on code you know will be obsolete, and that delays getting work done to

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

graesslin added a comment. I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

ngraham added a comment. +1 for not letting the perfect be the enemy of the good here. Multi-monitor support is a pain point for many of our users. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: ngraham, graesslin, davidedmundson,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > So I wouldn't trust this thing in Qt to work due to the pain we have in KWin especially with these problems. Yes, it might not be perfect. It works well enough that not exposing this in the settings is a wasted opportunity though. I used this extensively for

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

graesslin added a comment. I also cannot imagine this to work due to the fact how X11 works. There is just no mapping from window to screen. No window can know on which screen it is. Not even KWin knows that as the window manager (screen is not a constant property, but evaluated every time

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really wrong. Exactly that is not the case. Let me give you an example for

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. I can't imagine this working. It didn't when I've tried the same thing. Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Qt computes the scale factor relative to the primary screen. This means we can support per-screen DPI on X11 by setting