D12536: [timer applet] Change how time is tracked

broulik added a comment. I think a C++ part should be added using `QElapsedTimer` and then a display update timer REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12536 To: mmazur, #plasma, davidedmundson Cc: broulik, ngraham, davidedmundson, plasma-devel,

D12536: [timer applet] Change how time is tracked

ngraham added a comment. Fixed in D13065 ; this can be Abandoned. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12536 To: mmazur, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D12536: [timer applet] Change how time is tracked

mmazur added a comment. In D12536#254280 , @davidedmundson wrote: > > I was hoping the reviewer wouldn't notice. > > :/ > Had you said it explicitly I probably would have been fine with it. I'm operating on the assumption that

D12536: [timer applet] Change how time is tracked

davidedmundson added a comment. > I was hoping the reviewer wouldn't notice. :/ Had you said it explicitly I probably would have been fine with it. > As far as interacting with me goes, it's either merge my code with minor improvements here and there I understand your time is

D12536: [timer applet] Change how time is tracked

mmazur added inline comments. INLINE COMMENTS > mmazur wrote in TimerView.qml:56 > I wasn't aware that Date().getTime() wasn't in UTC. I can change it to a UTC > call if there is one. > > I'm aware of the sleep behavior change, however I do not know how to handle > it. (I was hoping the

D12536: [timer applet] Change how time is tracked

mmazur added inline comments. INLINE COMMENTS > davidedmundson wrote in TimerView.qml:54 > that's a lot of wakeups. Do you really need to do this? Typical display is 60Hz, so 16.6 ms per frame. A 20ms interval means each clock tick will be displayed between 58-62 frames after the previous one,

D12536: [timer applet] Change how time is tracked

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > TimerView.qml:54 > id: t; > -interval: 1000; > +interval: 20; > onTriggered: { that's a lot of wakeups. Do

D12536: [timer applet] Change how time is tracked

mmazur created this revision. mmazur added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mmazur requested review of this revision. REVISION SUMMARY Stop relying on QtQuicks Timer type to be precise and instead use