D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

bshah closed this revision. bshah added a comment. This was merged in https://phabricator.kde.org/D21362 , thanks for your patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, #plasma, mart Cc: bshah, rkflx, ngraham, mart, plasma-devel,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. Ping? @progwolff? I just tried this out again in a fresh Neon dev unstable VM after rebasing on master and fixing the merge conflicts and got the same result: the settings in the KCM accurately depict the fontconfig's default settings, but they're not actually

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. Ping? Is this ready for review again? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, #plasma Cc: rkflx, ngraham, mart, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. Are there any other outstanding issues, or is this ready for review? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham resigned from this revision. ngraham added a comment. OK, maybe there's something weird with my config somehow. :/ Can anyone else reproduce? In the meantime @progwolff, maybe it would be best to continue anyway until and unless anyone else can confirm my issue. Is this

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I installed a fresh Neon (dev unstable), removed the preinstalled files from /etc/fonts, copied your files to /etc/fonts and applied this patch. Still cannot reproduce your issue. F6216652: Screenshot_20180826_151000.png

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. I'm doing all my testing in a KDE Neon VM, FWIW. Would you be able to set that one up and try it there to see if you can reproduce it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I still cannot reproduce your issue. Any idea what I could try? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff planned changes to this revision. progwolff added a comment. In D12925#302675 , @ngraham wrote: > With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching the hinting style to Full, but then after switching back to something else and then back to Full again, it no longer worked and

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38969. progwolff added a comment. - fix writing config temporarily (previews) with missing local config entries REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38829=38969 BRANCH arcpatch-D12925

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. Sure, here you go: F6167313: fonts.tar.gz REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. could you give me all those files? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. cat ~/.config/fontconfig/fonts.conf ~/.fonts true ls /etc/fonts/conf.d 10-antialias.conf 57-dejavu-serif.conf 10-hinting-slight.conf

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. Works for me F6167260: Screenshot_20180731_164900.png Could you show me your `~/.config/fontconfig/fonts.conf` and the content of `/etc/fonts/conf.d`? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. On the other hand, no matter what combination of sub-pixel antialiasing and hinting style I suggest, and regardless of what default value is shown in the UI, the result seems

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. In D12925#301133 , @progwolff wrote: > I am not sure about the case when neither global nor local configs exist for subpixel or hint. > On my system it seems like rgb subpixel rendering with slight hinting is used

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38829. progwolff added a comment. - fix previews REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38828=38829 BRANCH arcpatch-D12925 REVISION DETAIL https://phabricator.kde.org/D12925 AFFECTED

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I am not sure about the case when neither global nor local configs exist for subpixel or hint. On my system it seems like rgb subpixel rendering with slight hinting is used when no configs exist. But I cannot find any documentation on this. We also need to

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38828. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925 - Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925 - also drop vendor-default-option for

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham requested changes to this revision. ngraham added a reviewer: Plasma. ngraham added a comment. This revision now requires changes to proceed. Nice! Two nitpicks: - `Anti-aliasing: [x] Use antialiasing` Either change the checkbox's label to "Enable", or remove the left label and

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38764. progwolff added a comment. - split changes to previewimageprovider.cpp to a separate commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38757=38764 BRANCH arcpatch-D12925 REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. Big sorry for being away for so long. I had some things to do that took much more time than initally planned. Many thanks to those who fixed the bugs I introduced or created workarounds... I tried to get this patch working now. First of all, I want to say a

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38757. progwolff added a comment. Rebase on master. Partial rewrite. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34315=38757 BRANCH arcpatch-D12925 REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. In D12925#264085 , @rkflx wrote: > I'll resume testing once this works a bit better. I'd say let's not rush this, and get it right for 5.14. I agree. Thanks for investigating! REPOSITORY R119 Plasma Desktop

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

rkflx added a comment. Hm, repeatedly pressing the Defaults button works really weird for me, and in some cases clicking on Disabled from… does not activate the option and only enables the widgets below (I need a second click for actually switching the radio selection). I'll resume

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

rkflx added a comment. You might want to rebase on the latest changes to D12849 (currently the patch only applies against `arc pat --diff 34209`, i.e. a previous version of D12849 ), and here set D12849

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

rkflx resigned from this revision. rkflx added a comment. Sorry for resigning as a reviewer, but currently I lack the time to review this in depth. Maybe I can do some basic testing tomorrow, but no promises. As said before though, conceptually this makes sense to me. IIUC, this is a

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 34315. progwolff added a comment. - remove unintentionally committed debug lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34274=34315 BRANCH fonts_kcm_globalConfigFiles (branched from master)

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. +1 conceptually; "Vendor Default" was always really awkward to explain to people. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, rkflx Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. In D12925#263459 , @mart wrote: > if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way? Just don't change anything in the kcm. The global config files are

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

mart added a comment. if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, rkflx Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 34274. progwolff added a comment. - Fix 'disabled from' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34272=34274 BRANCH fonts_kcm_globalConfigFiles (branched from master) REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff created this revision. progwolff added a reviewer: rkflx. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The fonts kcm did only parse a local config file. Global and