D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. One last word about the necessity of this arrow. To me the arrow is mandatory as soon as it refers to an action that is different than the one of the icon. (either long press, or extra menu beside the icon main action). Still to me, opening a menu when

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. In D13064#267463 , @ngraham wrote: > Got the chance to test this out. Functionally, it works great, and resolves the issue! > > Visually, I can understand you guys's hesitation about bringing the arrows

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. Got the chance to test this out. Functionally, it works great, and resolves the issue! Visually, I can understand you guys's hesitation about bringing the arrows back, because they do seem to lack that //je-ne-sais-quoi//, somehow. I wonder if the arrow might

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. I don't object to your proposal per se, but I don't think it goes far enough to address the need here. Let me give you a specific example I'm familiar with: I recently submitted a patch (https://phabricator.kde.org/D13026) to fix a functional problem with Kate's

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

abetts added a comment. In D13064#267368 , @ngraham wrote: > In D13064#267358 , @hpereiradacosta wrote: > > > Should we also add a symbol on icons to say that they are non-dangerous ? (even if not

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. In D13064#267358 , @hpereiradacosta wrote: > Should we also add a symbol on icons to say that they are non-dangerous ? (even if not a menu ?) In fact, we already do signal danger by using red icons for

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. In D13064#267357 , @abetts wrote: > In D13064#267356 , @ngraham wrote: > > > 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. I really don't understand the fear factor and unknown action argument. There are tooltips, possibly text alongside (or below icon), and the icon itself. Also, if you have to fear what an application might do to the point that you will only click on menus and

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

abetts added a comment. In D13064#267356 , @ngraham wrote: > 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal that these buttons will bring up a menu because without that, there is no way to distinguish it

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal that these buttons will bring up a menu because without that, there is no way to distinguish it from an ordinary action button. It's the same reason why comboboxes have arrows

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

abetts added a comment. In D13064#267117 , @hpereiradacosta wrote: > I am not particularly excited by the change, because on how it breaks the spacing between buttons in a toolbar. > I am also not completely convinced that it is important to

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. I am not particularly excited by the change, because on how it breaks the spacing between buttons in a toolbar. I am also not completely convinced that it is important to convey the information that a menu will open when you press on the button (because you

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. How it looks for the sorting button in Open dialog: F5865249: Screenshot_20180523_172606.png Gwenview "share" button: F5865251: Screenshot_20180523_172825.png

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta updated this revision to Diff 34723. hpereiradacosta added a comment. Removed unrelated change REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13064?vs=34720=34723 BRANCH master-toolbuttons REVISION DETAIL

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hpereiradacosta requested review of this revision. REVISION SUMMARY As discussed in bug 344746 this helps identifying which toolbuttons will trigger