This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ee8e49422118: Abort transaction on PackageKit errors
(authored by arojas).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13119?vs=34886=34907
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Looks better, thanks!
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D13119
To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
arojas updated this revision to Diff 34886.
arojas added a comment.
Remove wrong check for !m_proceedFunctions.isEmpty()
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13119?vs=34881=34886
REVISION DETAIL
arojas updated this revision to Diff 34881.
arojas added a comment.
Check for ExitStatus in cleanup() and move setStatus there
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13119?vs=34873=34881
REVISION DETAIL
apol added a comment.
Looks like it's missing checking the `exit` argument in ::cleanup() for
`ExitFailed` no? Can you check if in this case we're getting the an ExitFailed?
If so the setStatus should go there.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
arojas created this revision.
arojas added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.
REVISION SUMMARY
If PackageKit throws a dependency resolution error, abort the
