D13141: Touchpad KCM Redesign Using Kirigami

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:dd1244d66766: Touchpad KCM Redesign Using Kirigami (authored by furkantokac). REPOSITORY R119 Plasma Desktop

D13141: Touchpad KCM Redesign Using Kirigami

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

ngraham accepted this revision. ngraham added a comment. Looks grand now! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35554. furkantokac added a comment. Combobox is expanded. MiddleEmulayion string is changed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=35545=35554 BRANCH arcpatch-D13141 REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:200 > +id: middleEmulation > +text: i18n("Clicking left and right for middle button") > + "Press left and right buttons

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. If we're keeping the combobox on top, it needs to be wide enough to show the full string. Otherwise it's not only functionally useless 99.99% of the time, it's also uninformative. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35545. furkantokac added a comment. Combobox is always visible. Combobox manual resizing is removed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=35527=35545 BRANCH arcpatch-D13141 REVISION

D13141: Touchpad KCM Redesign Using Kirigami

romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:101 > +enabled: touchpadCount > 1 > +visible: touchpadCount > 1 // Invisible if there is only 1 > touchpad device > +

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35527. furkantokac added a comment. Tapping strings are changed. Natural scrolling string is added. If there is only 1 touchpad, device combobox set to insvisible. ScrollablePage is changed with Page. REPOSITORY R119 Plasma Desktop CHANGES

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269989 , @ngraham wrote: > Here's another idea for the multi-tapping radio button to reduce the string length: > > Two-finger tap: (o) Right-click (three-finger tap to middle-click) >

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. Here's another idea for the multi-tapping radio button to reduce the string length: Two-finger tap: (o) right-click (three-finger tap to middle-click) ( ) middle-click (three-finger tap to right-click) REPOSITORY R119 Plasma Desktop

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added inline comments. INLINE COMMENTS > main.qml:439 > +id: naturalScroll > +text: i18n("Invert scroll direction") > + Idea: change this string to: > Invert scroll direction ("Natural scrolling") This might help improve discoverability for people who are

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. Another idea: omit the always-disabled "Device" combobox when there's only a single device. It's not doing much good in that situation. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added inline comments. INLINE COMMENTS > main.qml:373 > +if (touchpad.tapFingerCount > 2) { > +model = [i18n("Two finger tap right-click, three finger > tap middle-click"), > + i18n("Two finger tap middle-click, three

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. The middle click emulation issue is tricky because the behavior and available options are different depending on the hardware configuration, and, if using a buttonless touchpad, also the click method used. I wonder if we need to make the UI dynamically adapt to the

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269402 , @ngraham wrote: > Sadly, Libinput only allows one scrolling method to be active at once. See https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html > > So until and unless we can

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35066. furkantokac added a comment. "NoScroll" setting is removed. Feedbacks are applied. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=34950=35066 BRANCH kcmtouchpad-kirigamidesign REVISION

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. Sadly, Libinput only allows one scrolling method to be active at once. See https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html So until and unless we can change Libinput itself, this has to stay as a radio button. REPOSITORY R119 Plasma Desktop

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269312 , @esedgh wrote: > Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development. > > But now that you're at it, I may give you a bit of feedback

D13141: Touchpad KCM Redesign Using Kirigami

esedgh added a comment. Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development. But now that you're at it, I may give you a bit of feedback in here. Touchpad settings has "Two Finger Scrolling" and "Edge Scrolling" as a radio

D13141: Touchpad KCM Redesign Using Kirigami

knambiar added a comment. > - "Two tap right, three middle" -> "Tap twice for right-click; three times for middle-click" > - "Two tap middle, three right" -> "Tap twice for middle-click; three times for right-click" May be clearer to use: “Two tap right, three middle” → “Tap two

D13141: Touchpad KCM Redesign Using Kirigami

abetts added a comment. In D13141#268862 , @ngraham wrote: > As for wanting to making this non-scrollable: in general, we should aspire for the main views of our KCMs to never require scrolling (subviews like tables are okay, of course). It's

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. As for wanting to making this non-scrollable: in general, we should aspire for the main views of our KCMs to never require scrolling (subviews like tables are okay, of course). It's very awkward to able to scroll a UI that's packed full of UI controls. It can even

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. "Speed profile" sounds weird (in English, at least). For now, let's go with: Pointer speed: -I-- Acceleration profile: (o) Flat ( ) Adaptive REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:94 > +enabled: touchpadCount > 1 > +//Layouts.Layout.fillWidth: true > +implicitWidth: units.gridUnit * 10 This will go if nobody tells me it is necessary. I couldn't find any use case that this

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. @romangg There are some "TODO"s in the code. Please tell me if they still need to be applied so I'll do them, if they are not, I'll remove them. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#268853 , @ngraham wrote: > Is the user-facing control for the click method (areas or clickfinger) going to come in a separate patch? It might make sense to add

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. In general much nicer! Is the user-facing control for the click method (areas or clickfinger) going to come in a separate patch? It might make sense to add that feature first and then we can do all the UI review in a single patch. Why is "acceleration

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 34950. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=34949=34950 BRANCH kcmtouchpad-kirigamidesign REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:466 > +} // END Kirigami.FormLayout > +} // END KCM.SimpleKCM This comment will be changed as "END Kirigami.ScrollablePage" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY Touchpad KCM is redesigned in Kirigami. Tested in Wayland+Libinput and Xorg+Libinput.