broulik added inline comments.
INLINE COMMENTS
> ContextMenu.qml:486
>
> -checkable: true
> -
> -text: i18nc("Toggle action for showing a launcher button while the
> application is not running", "")
> +text: (isPinned ? i18nc("Action for removing the launcher button
>
ngraham added a comment.
+1 conceptually, and works fine for me.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13788
To: hein, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
hein created this revision.
hein added a reviewer: broulik.
Restricted Application added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Previously it used a checkable/toggle action, while launcher tasks
used Pin/Unpin. This is more consistent, and it means there's