D13788: Use Pin/Unpin also for window tasks when there's only one activity

2018-06-29 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ContextMenu.qml:486 > > -checkable: true > - > -text: i18nc("Toggle action for showing a launcher button while the > application is not running", "") > +text: (isPinned ? i18nc("Action for removing the launcher button >

D13788: Use Pin/Unpin also for window tasks when there's only one activity

2018-06-28 Thread Nathaniel Graham
ngraham added a comment. +1 conceptually, and works fine for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13788 To: hein, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13788: Use Pin/Unpin also for window tasks when there's only one activity

2018-06-28 Thread Eike Hein
hein created this revision. hein added a reviewer: broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Previously it used a checkable/toggle action, while launcher tasks used Pin/Unpin. This is more consistent, and it means there's