D13988: Use subseq matching for service runner

ngraham closed this revision. ngraham added a comment. Manually merged because `arc land` doesn't seem to want to work anymore. You can see it at //invent.kde.org/plasma/plasma-workspace/commit/9f2abd0a54d51d9234a5a9489d1342b261429fa3. Thanks Michael! REPOSITORY R120 Plasma Workspace

D13988: Use subseq matching for service runner

ngraham added a comment. Still applies cleanly and seems to fix the bug. Landing. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham Cc: meven,

D13988: Use subseq matching for service runner

meven added a comment. There no blockers anymore, providing there no conflict, we could land this as-is. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik,

D13988: Use subseq matching for service runner

justinzobel added a comment. Can we please move this to and rebase? https://invent.kde.org/plasma/plasma-workspace/-/merge_requests REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas,

D13988: Use subseq matching for service runner

broulik added a comment. Apparently you have to tell sysadmin two weeks in advance. [1] [1] https://mail.kde.org/pipermail/plasma-devel/2018-August/087983.html REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To:

D13988: Use subseq matching for service runner

michaeleden added a comment. @broulik thanks, will do! REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham Cc: cfeck, ngraham, plasma-devel, ragreen,

D13988: Use subseq matching for service runner

broulik added a comment. Please only change dependency to a released version otherwise this will break the build for everyone. Feel free to bump to 5.49 once it's released (next week?) REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL

D13988: Use subseq matching for service runner

michaeleden added a comment. @ngraham cool! So I should change the deps for KF 5.50 unless someone else disagrees? REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma,

D13988: Use subseq matching for service runner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic. This works great for me, but let's get some more opinions too. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL

D13988: Use subseq matching for service runner

cfeck added a comment. According to https://community.kde.org/Schedules/Plasma_5 the Plasma 5.14 release is planned to depend on Frameworks 5.50. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma,

D13988: Use subseq matching for service runner

ngraham added a comment. Nah, let's wait. We'll have to see what the dependency plans are for Plasma; I'm not sure whether or not we'll be depending on Frameworks 5.49 for Plasma 5.14. Might wanna ask one of the #plasma folks. REPOSITORY R120

D13988: Use subseq matching for service runner

michaeleden added a comment. @ngraham this didn't make it into 5.48 but it did make it into the commit after that. Should I put 5.49 even though its not tagged yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas,

D13988: Use subseq matching for service runner

ngraham added a comment. `plasma-workspace` does compile without D13670 and KRunner //seems// to work, but it gives me a whole lotta console spew: kf5.kservice.services: Parsing "exist Exec and ( (exist Keywords and 'scover' ~subin Keywords) or

D13988: Use subseq matching for service runner

ngraham added reviewers: Plasma, broulik. ngraham added a comment. > This fixes B262837 (how do you show this in phab?) and relies on D13670 Like so: :) BUG: 262837 Depends on D13670 See

D13988: Use subseq matching for service runner

michaeleden created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaeleden requested review of this revision. REVISION SUMMARY This changes krunner to use sub-sequence matching fixing bug 262837. REPOSITORY R120