D14011: Use PlasmaComponents for Label

2018-07-09 Thread Bo Simonsen
bosimonsen added a comment. In D14011#289661 , @broulik wrote: > You can mix the two, just import it with a namespace > > import QtQuick.Controls 2.0 as QQC2 > > > and then `QQC2.Label`. I think it's still fine for 5.12 even this way.

D14011: Use PlasmaComponents for Label

2018-07-09 Thread Kai Uwe Broulik
broulik added a comment. You can mix the two, just import it with a namespace import QtQuick.Controls 2.0 as QQC2 and then `QQC2.Label`. I think it's still fine for 5.12 even this way. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To:

D14011: Use PlasmaComponents for Label

2018-07-09 Thread Bo Simonsen
bosimonsen added a comment. In D14011#289654 , @broulik wrote: > -1 > > Don't use Plasma components in "widget" Ui. Use `QtQuick.Controls 2` instead ScrollView is not available in QtQuick.Controls 2.0 appears to be at a later

D14011: Use PlasmaComponents for Label

2018-07-09 Thread Kai Uwe Broulik
broulik added a comment. -1 Don't use Plasma components in "widget" Ui. Use `QtQuick.Controls 2` instead REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14011: Use PlasmaComponents for Label

2018-07-09 Thread Bo Simonsen
bosimonsen updated this revision to Diff 37481. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14011?vs=37477=37481 REVISION DETAIL https://phabricator.kde.org/D14011 AFFECTED FILES Modules/energy/package/contents/ui/main.qml

D14011: Use PlasmaComponents for Label

2018-07-09 Thread Bo Simonsen
bosimonsen created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bosimonsen requested review of this revision. REVISION SUMMARY The Label in QtQuick.Controls is only using renderType Text.QtRendering for mobile devices.