D14025: Move scale and unify button to the top, next to primary combo

2018-07-13 Thread Thomas Pfeiffer
colomar added a comment. In D14025#291499 , @davidedmundson wrote: > It (currently) depends. There are two scale UI options with the appropriate one visible. > > The global scale factor for X is the only one that's moved. Ah, cool,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-13 Thread David Edmundson
davidedmundson added a comment. It (currently) depends. There are two scale UI options with the appropriate one visible. The global scale factor for X is the only one that's moved. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn, #vdg,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-13 Thread Thomas Pfeiffer
colomar added a comment. The Unify Outputs button definitely makes sense to be there, but I'm not sure about the "Scale display" button. The "Primary display" selection and the Unify Outputs button both affect the whole setup, whereas Scale Display only affects the selected display,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-11 Thread Frederik Gladhorn
gladhorn closed this revision. gladhorn added a comment. Pushed, sadly without the phabricator tag, since I'm struggling to manage > 1 patch with phabricator. b01b567296b70b9b593eaa438d86dffe7b663afa REPOSITORY

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 In D14025#289826 , @gladhorn wrote: > depends on https://phabricator.kde.org/D14024 The correct way to express this is:

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Frederik Gladhorn
gladhorn added a comment. depends on https://phabricator.kde.org/D14024 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn, #vdg, #plasma, sebas Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Frederik Gladhorn
gladhorn added a comment. This is at least a first step in making the UI a bit nicer. And imho it's a low-hanging fruit. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Frederik Gladhorn
gladhorn added a comment. after: F6067891: kscreen_kcm_after.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Frederik Gladhorn
gladhorn added a comment. before: F6067872: kscreen_kcm_before.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Kai Uwe Broulik
broulik added a comment. Please add a screenshot when you do UI changes REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Frederik Gladhorn
gladhorn added a comment. The diff is confusing. It actually moves the buttons into the other layout :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-10 Thread Frederik Gladhorn
gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH gladhorn/ui REVISION DETAIL https://phabricator.kde.org/D14025 AFFECTED