D14350: Make sure for loop does not detach

2018-07-27 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes. Closed by commit R110:7cbccda5a273: Make sure for loop does not detach (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14350?vs=38426=38584 REVISION

D14350: Make sure for loop does not detach

2018-07-25 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 38426. gladhorn added a comment. Use a temporary const for ranged for REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14350?vs=38375=38426 BRANCH arcpatch-D14350 REVISION DETAIL

D14350: Make sure for loop does not detach

2018-07-25 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > config.cpp:371 > dbg << "KScreen::Config("; > -for (const auto output : config->outputs()) { > +for (const auto : config->outputs()) { > if (output->isConnected()) { This still calls

D14350: Make sure for loop does not detach

2018-07-25 Thread Frederik Gladhorn
gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL