D14405: Use short pnp id as fallback when the DB file is not found

2018-07-27 Thread Frederik Gladhorn
gladhorn added a comment. I think the qml code should not do logic fiddling with the EDID :) but needs investigation. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot

D14405: Use short pnp id as fallback when the DB file is not found

2018-07-27 Thread Frederik Gladhorn
gladhorn added a comment. Good catch, I'll have to look into it, right now I get an empty string for both. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D14405: Use short pnp id as fallback when the DB file is not found

2018-07-27 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Where vendor is used in the output display we do: text: ... } else if (root.output.edid && root.output.edid.vendor) { return root.outpu

D14405: Use short pnp id as fallback when the DB file is not found

2018-07-26 Thread Frederik Gladhorn
gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY At least on arch linux pnp.ids does not even exist (while usb.ids and pci.ids do). There seem t