D14418: Add test for edid parsing and fix reading gamma

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b80bbeb2e419: Add test for edid parsing and fix reading gamma (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38594=38604

D14418: Add test for edid parsing and fix reading gamma

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. > The old code's output was "2.0" instead of "2.2": integer division first, then cast. Yes, I know. But my train of thoughts was that the original value was multiplied by 100 when

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38594. gladhorn added a comment. arc messup, it squashed another patch into this one REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38592=38594 REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38592. gladhorn edited the summary of this revision. gladhorn added a subscriber: romangg. gladhorn added a comment. Updated commit message and rebased. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38590. gladhorn added a comment. Sort edids in test rows. I still think this is completely pointless and a waste of time. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38588=38590 BRANCH

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38588. gladhorn added a comment. Removed xfail, it was fixed by the string parsing fix REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38565=38588 BRANCH arcpatch-D14418_1 REVISION DETAIL

D14418: Add test for edid parsing and fix reading gamma

gladhorn added a comment. In D14418#299028 , @romangg wrote: > I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and

D14418: Add test for edid parsing and fix reading gamma

romangg added a comment. I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and nothing gets truncated. But we can still go with the updated code, which looks nicer.

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38565. gladhorn added a comment. Added one more edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38564=38565 BRANCH arcpatch-D14418 REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38564. gladhorn added a comment. Removed some extra parenthesis REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38553=38564 BRANCH arcpatch-D14418 REVISION DETAIL

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38553. gladhorn added a comment. Remove extra newline REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38550=38553 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38550. gladhorn added a comment. Minor cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38549=38550 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED FILES

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38549. gladhorn added a comment. Simplify gamma parsing code REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38548=38549 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The bug in reading the gamma value was there from the start (2012), dividing the number by 100