This revision was automatically updated to reflect the committed changes.
Closed by commit R110:e6b197b47b8a: Define ownership of edid in output and do
not leak it (authored by gladhorn).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14428?vs=38600&id=46182#toc
REPOSITORY
R110 KScreen
gladhorn added a comment.
The alternative would be to deprecate this and add a new function. I think
this is nonetheless sensible.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D14428
To: gladhorn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezh
gladhorn updated this revision to Diff 38600.
gladhorn added a comment.
Messed up merge :(
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14428?vs=38599&id=38600
REVISION DETAIL
https://phabricator.kde.org/D14428
AFFECTED FILES
src/output.cpp
gladhorn updated this revision to Diff 38599.
gladhorn added a comment.
Add note about the edid pointer becoming invalid
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14428?vs=38598&id=38599
REVISION DETAIL
https://phabricator.kde.org/D14428
AF
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
Valgrind showed that in some cases we were leaking the edid in