This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when
QMLScreen is destroyed (authored by gladhorn).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
It's good to go.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14478
To: gladhorn, #plasma, davidedmundson
Cc: romangg, broulik, davidedmundson,
romangg added a comment.
I also thought the call to setParentItem would clear the output. But as
@broulik says it does not delete automatically. So is this good to go? Or
should we make QMLScreen really a Qt Object parent of the outputs?
REPOSITORY
R104 KScreen
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in qmlscreen.cpp:96
> this should clear them already?
`parentItem` is only visual parent, it doesn't communicate ownership
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14478
To: gladhorn,
davidedmundson added inline comments.
INLINE COMMENTS
> qmlscreen.cpp:96
>
> qmloutput->setParentItem(this);
> qmloutput->setZ(m_outputMap.count());
this should clear them already?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14478
To: gladhorn,
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
In practice this is most likely only a leak on exit which does
