D15226: Check against QRect whether pointer is inside DecorationButton

This revision was automatically updated to reflect the committed changes. Closed by commit R129:c9cfd840137b: Check against QRect whether pointer is inside DecorationButton (authored by zzag). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

D15226: Check against QRect whether pointer is inside DecorationButton

davidedmundson accepted this revision. davidedmundson added a comment. thanks REPOSITORY R129 Window Decoration Library BRANCH fix-hover-with-zero-spacing REVISION DETAIL https://phabricator.kde.org/D15226 To: zzag, #kwin, davidedmundson Cc: davidedmundson, plasma-devel, ragreen,

D15226: Check against QRect whether pointer is inside DecorationButton

zzag updated this revision to Diff 40905. zzag added a comment. Add `contais` method REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15226?vs=40900=40905 BRANCH fix-hover-with-zero-spacing REVISION DETAIL

D15226: Check against QRect whether pointer is inside DecorationButton

zzag added a comment. In D15226#319409 , @davidedmundson wrote: > would adding > > bool DecorationButton::contains(QPoint) const > > make sense? Yes, it would. I'll add this method. :-) REPOSITORY R129 Window Decoration

D15226: Check against QRect whether pointer is inside DecorationButton

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. would adding bool DecorationButton::contains(QPoint) const make sense? INLINE COMMENTS > decoration.cpp:386 > for (DecorationButton *button : d->buttons) { >

D15226: Check against QRect whether pointer is inside DecorationButton

zzag updated this revision to Diff 40900. zzag added a comment. Add test REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15226?vs=40876=40900 BRANCH fix-hover-with-zero-spacing REVISION DETAIL https://phabricator.kde.org/D15226

D15226: Check against QRect whether pointer is inside DecorationButton

zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY If several buttons share an edge, i.e. spacing between decoration buttons is set to 0, and the pointer is on that edge, both buttons