This revision was automatically updated to reflect the committed changes.
Closed by commit R169:301af35592af: Remove some double look-ups (authored by
apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15243?vs=40947=40984
REVISION DETAIL
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> broulik wrote in delegaterecycler.cpp:73
> `m_refs.erase(itRef)`?
Thanks!
> broulik wrote in delegaterecycler.cpp:83
> Unrelated question: Where does this get removed from `items`?
They are unused items
apol updated this revision to Diff 40947.
apol marked an inline comment as done.
apol added a comment.
Remove another lookup, thanks Kai!
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15243?vs=40919=40947
BRANCH
arcpatch-D15243
REVISION DETAIL
broulik added a comment.
+1
INLINE COMMENTS
> delegaterecycler.cpp:73
> +if (*itRef <= 0) {
> m_refs.remove(component);
> +
`m_refs.erase(itRef)`?
> delegaterecycler.cpp:83
> +if (items.length() >= s_cacheSize) {
> item->deleteLater();
> return;
apol updated this revision to Diff 40919.
apol added a comment.
Add missing part
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15243?vs=40915=40919
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15243
AFFECTED FILES
apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
TEST PLAN
My apps still work
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
