D15827: [applet] Avoid showing a generic audio-card icon

2018-10-04 Thread Nathaniel Graham
ngraham added a comment. Great idea. Then the click target becomes much bigger and muting is easier. If we do that, we'd probably want to badge the icon with `emblem-unavailable` so that it's clear that that stream is muted. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL htt

D15827: [applet] Avoid showing a generic audio-card icon

2018-10-04 Thread Nicolas Fella
nicolasfella added a comment. In D15827#336757 , @ngraham wrote: > I think showing a generic speaker or microphone icon is a //huge// visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them. > > Here's

D15827: [applet] Avoid showing a generic audio-card icon

2018-10-04 Thread Nathaniel Graham
ngraham added a comment. I think showing a generic speaker or microphone icon is a //huge// visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them. Here's an idea: It's completely obvious what the sliders are for, so just get rid of the little one

D15827: [applet] Avoid showing a generic audio-card icon

2018-10-04 Thread David Rosca
drosca added a comment. I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "in

D15827: [applet] Avoid showing a generic audio-card icon

2018-09-28 Thread Nathaniel Graham
ngraham added a comment. Possibly related information: I believe the original change that resulted in sound card icons everywhere was D8054 . In particular, read https://phabricator.kde.org/D8054#252877. REPOSITORY R115 Plasma Audio Volume Applet REVISIO

D15827: [applet] Avoid showing a generic audio-card icon

2018-09-28 Thread Nathaniel Graham
ngraham added a comment. +10 on the end goal of showing speaker or microphone icons instead of a generic sound card icon! I'm not sure this is the best way to achieve that though. I'm sure @drosca will be able to offer some guidance here. REPOSITORY R115 Plasma Audio Volume Applet REVISIO

D15827: [applet] Avoid showing a generic audio-card icon

2018-09-28 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: drosca, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY If the hardware reports "internal" as formfactor the generic audio