D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham added a comment. With the benefit of a good nightly sleep, I can see now that my comment was really passive-aggressive, for which I apologize. You're right, of course. Thanks for the quick fix! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15855

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein added a comment. In D15855#362015 , @ngraham wrote: > @hein This broke the scrollbar for any views that are scrollable. Now the scrollbars don't accept clicks and drags anymore, and don't change on hover. Maybe the MouseArea doesn't pass

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham added a comment. @hein This broke the scrollbar for any views that are scrollable. Now the scrollbars don't accept clicks and drags anymore, and don't change on hover. Maybe the MouseArea doesn't pass on the mouse events to the ScrollArea underneath it or something? We can't

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham added a comment. Oops, sorry, I forgot to change my status! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15855 To: hein, #plasma, ngraham, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15855: Port Kickoff to shared view component using single-MouseArea pattern

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:48b32259e73f: Port Kickoff to shared view component using single-MouseArea pattern (authored by hein). REPOSITORY

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in KickoffListView.qml:57 > This already is a focusScope > > could this not be the root item? I don't think so because I need the MouseArea to cover the ScrollArea, but the ScrollArea has to manage its single child (the

D15855: Port Kickoff to shared view component using single-MouseArea pattern

davidedmundson added inline comments. INLINE COMMENTS > KickoffListView.qml:57 > + > +PlasmaExtras.ScrollArea { > +id: scrollArea This already is a focusScope could this not be the root item? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15855

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein updated this revision to Diff 42841. hein added a comment. Add missing file, d'oh. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15855?vs=42596=42841 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15855 AFFECTED FILES

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now Kickoff doesn't open. When I click on it, I get a little error pop-up that says: Error loading QML file:

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein updated this revision to Diff 42596. hein added a comment. Update copyright years REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15855?vs=42595=42596 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15855 AFFECTED FILES

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein updated this revision to Diff 42595. hein added a comment. Focus scope handling. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15855?vs=42594=42595 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15855 AFFECTED FILES

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This: - Moves MouseArea out of the item delegate and uses a single MouseArea per view. - Ports all the pages to using a shared view