D16073: openconnect: add missing dependency Qt5Xml

This revision was automatically updated to reflect the committed changes. Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D16073: openconnect: add missing dependency Qt5Xml

asturmlechner added a comment. In D16073#340107 , @alexeymin wrote: > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory` then fine... Yes, it was exactly that:

D16073: openconnect: add missing dependency Qt5Xml

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5 Probably this commit could remove dependency on QtXml (I'm not

D16073: openconnect: add missing dependency Qt5Xml

asturmlechner updated this revision to Diff 43221. asturmlechner added a comment. Only pull in Qt5Xml if OpenConnect is requested. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16073?vs=43220=43221 BRANCH Plasma/5.14 REVISION

D16073: openconnect: add missing dependency Qt5Xml

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY QDomDocument is imported from vpn/openconnect/openconnectauth.cpp TEST PLAN