D16897: Allow windows to be closed from the window switchers

ngraham abandoned this revision. ngraham added a comment. Continued at https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/5 and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/115 REPOSITORY R114 Plasma Addons REVISION DETAIL

D16897: Allow windows to be closed from the window switchers

graesslin added a comment. In D16897#359912 , @ngraham wrote: > In D16897#359911 , @graesslin wrote: > > > In D16897#359900 , @ngraham wrote: > > > >

D16897: Allow windows to be closed from the window switchers

ngraham added a comment. In D16897#359911 , @graesslin wrote: > In D16897#359900 , @ngraham wrote: > > > Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin

D16897: Allow windows to be closed from the window switchers

graesslin added a comment. In D16897#359900 , @ngraham wrote: > Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's codebase!). I would

D16897: Allow windows to be closed from the window switchers

ngraham planned changes to this revision. ngraham added a comment. Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's codebase!). REPOSITORY R114 Plasma Addons REVISION DETAIL

D16897: Allow windows to be closed from the window switchers

graesslin added a comment. I agree with David: please don't hardcode the key. Please don't use "W" - it has no meaning in a window manager, it's just the shortcut in some applications, others use Ctrl+Q and localized it could be something completely different. I suggest to implement

D16897: Allow windows to be closed from the window switchers

davidedmundson added a comment. You can do control+w with if (event.matches(StandardKey.Close)) { } alt+f4 would need some exposing on the kwin side as that's not a "standard key" exposed via the QPT REPOSITORY R114 Plasma Addons REVISION DETAIL

D16897: Allow windows to be closed from the window switchers

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. you can't hardcode the key combos REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16897 To: ngraham, #plasma, #vdg, davidedmundson

D16897: Allow windows to be closed from the window switchers

abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16897 To: ngraham, #plasma, #vdg Cc: abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

ngraham added a subscriber: Zren. ngraham added a comment. I'm also having trouble getting the same approach to work for the default Breeze switcher, which lives in plasma-workspace. Keyboard navigation with the arrow keys works, so the event handler is functional. But I can't seem to

D16897: Allow windows to be closed from the window switchers

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Implements the ability to close windows from the various non-default window switchers using