D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

Sweetchuck added a comment. F10621291: Screenshot_20220711_100038.png Operating System: openSUSE Tumbleweed 20220706 KDE Plasma Version: 5.25.2 KDE Frameworks Version: 5.95.0 Qt Version: 5.15.5 Kernel Version: 5.18.9-1-default (64-bit)

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R119:185c0d38381c: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen… (authored by GB_2, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47058. GB_2 added a comment. Hide the tooltip if you click on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47045=47058 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

Codezela added a comment. In D17323#372754 , @GB_2 wrote: > In D17323#372752 , @Codezela wrote: > > > when resizing the panel can we show the width of it > > 48px ,36px etc > > because now

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 added a comment. It's okay :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg, ngraham Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel,

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 added a comment. In D17323#372752 , @Codezela wrote: > when resizing the panel can we show the width of it > 48px ,36px etc > because now when I resize the panel I guess what better visually > but if I know the size exactly It will

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

Codezela added a comment. when resizing the panel can we show the width of it 48px ,36px etc because now when I resize the panel I guess what better visually but if I know the size exactly It will much better like all other panels latte dock for example REPOSITORY R119 Plasma

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47045. GB_2 added a comment. Fix tooltip text color (for real this time). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47041=47045 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47041. GB_2 added a comment. Fix text color. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47038=47041 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47038. GB_2 added a comment. Improve wording. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47033=47038 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This looks great to me now! Just one tiny little minor suggested wording change. Let's see what the #plasma folks think too. INLINE

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47033. GB_2 added a comment. Add tooltip for the resize button, change tooltip text and increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47011=47033 REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47011. GB_2 added a comment. Increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47010=47011 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47010. GB_2 added a comment. Improve code and add tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46973=47010 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. We're getting there! Right now, the tooltip appears if I click-and-hold for a moment, but not when I just click. Since that's the use case we're targeting, we should probably make it appear for click-and-quickly-release as well. INLINE COMMENTS >

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

trickyricky26 added a comment. Will that tooltip be shown when just clicking on the button without dragging? It would be very helpful to trigger the tooltip when the button is pressed, but not dragged. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46973. GB_2 added a comment. Add import. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46972=46973 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Oops, forgot the import... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46972. GB_2 added a comment. Use QQC2 tooltip. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46971=46972 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Hmm, that tooltip doesn't match the style. Why not use the QQC2 tooltip? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46971. GB_2 added a comment. Added the tooltip. F6459564: Panel Edit Mode Buttons (3).png It is ready now! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

davidedmundson added a comment. > Local workarounds for toolkit bugs are .. I fully 100% agree on that principle, but in this specific case from my tech POV, option 1 is fine too. Sizing items is typically in the jurisdiction of the app using the component rather than the component

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Ok, number two then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. In D17323#371825 , @GB_2 wrote: > 2. Align "Height/Width" button contents on the left side F6458265: Panel Edit Mode Buttons (2).png This is the choice that basically just

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Because https://phabricator.kde.org/D17355 is currently not working properly, we have two options: 1. Small "Height/Width" button F6458263: Panel Edit Mode Buttons (1).png 2. Align "Height/Width" button contents on

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Did we decide not to move forward with the idea of a tooltip, or is that being done in another patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Waiting for https://phabricator.kde.org/D17355 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Another revision, please. Thanks for all the great fixes here! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. I managed to fix it, but it the Plasma QML Button code needs to be changed. Should I create a new Phabricator revision or add it here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Hmm... when a button has an icon the content gets aligned on the left and I can't find a way to change it... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Oh, you mean the button content... I will try to fix that! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

matheusm added a comment. In D17323#370413 , @GB_2 wrote: > In D17323#370411 , @matheusm wrote: > > > +1, but why aren't the buttons content centered? > > > They are, do you think that because

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46749. GB_2 edited the summary of this revision. GB_2 added a comment. Update panel size button icons. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46741=46749 REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. In D17323#370411 , @matheusm wrote: > +1, but why aren't the buttons content centered? They are, do you think that because of the screenshot? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

matheusm added a comment. +1, but why aren't the buttons content centered? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. In D17323#370402 , @ngraham wrote: > Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p Yeah :P REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: ngraham, trickyricky26, #vdg, plasma-devel,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. In D17323#370396 , @trickyricky26 wrote: > This is awesome, thank you! > > If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Nice! While we're at it, what do you think about adding a tooltip saying "Drag to the screen edge where you would like this panel to love" or something? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

trickyricky26 added a comment. This is awesome, thank you! If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip appear when the user clicks on the button without dragging it? REPOSITORY R119

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Modifies the screen edge button and panel size button in the panel edit mode to make them easier to