This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e2aa89898db3: Check icon positions after move (authored
by McPain, committed by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
McPain added inline comments.
INLINE COMMENTS
> positioner.cpp:418
> + */
> +while ((!isBlank(to) && from != to) || toIndices.contains(to)) {
> to++;
AFAIK, the first part of condition is "check if `to` is blank and if it's not,
check whether we're not
McPain updated this revision to Diff 48238.
McPain added a comment.
Fixed condition mistake
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17809?vs=48220=48238
REVISION DETAIL
https://phabricator.kde.org/D17809
AFFECTED FILES
containments/desktop/plugins/folder/positioner.cpp
davidedmundson added a comment.
Looks sensible to me. Good stuff.
Wait a week to allow Eike a chance to comment, otherwise consider this a ship
it!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D17809
To: McPain
Cc: davidedmundson, plasma-devel, GB_2,
McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.
REVISION SUMMARY
BUG: 402574
When we're moving a bunch of icons to the area which is already busy, we
didn't check whether we're moving icons to
