D18269: Improve the Splash Screen KCM

GB_2 added a comment. In D18269#393711 , @ngraham wrote: > In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch. Ok, sorry. REPOSITORY R119 Plasma

D18269: Improve the Splash Screen KCM

ngraham added a comment. In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18269 To: GB_2, #plasma, #vdg, davidedmundso

D18269: Improve the Splash Screen KCM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd94db08a555: Improve the Splash Screen KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST U

D18269: Improve the Splash Screen KCM

GB_2 updated this revision to Diff 49544. GB_2 added a comment. Use old icon `preferences-system-splash` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18269?vs=49541&id=49544 BRANCH improve-splashscreen-kcm (branched from master) REVISION DETAIL

D18269: Improve the Splash Screen KCM

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm_splashscreen.desktop:2 > > so it wouldn't get done in time for the Plasma 5.15 release... > > It would be a runtime change, so if you got it in next frameworks it'd fix > itself midway through Plasma 5.15 beta. > > No

D18269: Improve the Splash Screen KCM

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GB_2 wrote in kcm_splashscreen.desktop:2 > Yes, I just used it because I think it should be included in Plasma 5.15 and > it is the closest to

D18269: Improve the Splash Screen KCM

GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in kcm_splashscreen.desktop:2 > Yes, I just used it because I think it should be included in Plasma 5.15 and > it is the closest to a login splash icon I could find. BTW, the Plymouth Splash KCM just uses an empty screen icon. REPOSITORY

D18269: Improve the Splash Screen KCM

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm_splashscreen.desktop:2 > I know you're making this change because we don't actually have a > `preferences-system-splash` icon, but is this really semantically correct? It > seems like we should actually create that icon, or mayb

D18269: Improve the Splash Screen KCM

ngraham added inline comments. INLINE COMMENTS > kcm_splashscreen.desktop:2 > [Desktop Entry] > -Icon=preferences-system-splash > +Icon=preferences-system-login > Exec=kcmshell5 kcm_splashscreen I know you're making this change because we don't actually have a `preferences-system-splash` icon

D18269: Improve the Splash Screen KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Splash Screen KCM has some inconsistencie