D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson resigned from this revision. davidedmundson added a comment. My opinion on top-down "lets shuffle things" remains the same. However, I am happy to approve iterative changes. I can see how this is a prerequisite to renaming "Workspace Theme" which seems to make sense, given

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Should we really wait until those are merged and not have the new layout in Plasma 5.16? Merging these will take quite some time and I don't see how it would make a difference layout-wise. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#446564 , @davidedmundson wrote: > From my last comment > > >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > > > > > This is by /far/ the

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson added a comment. From my last comment >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > This is by /far/ the most important step to do before shuffling top levels about. Otherwise you don't know what

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. In D18419#446142 , @GB_2 wrote: > In D18419#400163 , @davidedmundson wrote: > > > > Improve text on existing QWidgets KCMs to conform to the HIG > > > > After this. >

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#400163 , @davidedmundson wrote: > > Improve text on existing QWidgets KCMs to conform to the HIG > > After this. > > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG > >

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. I think we should really move the LnF KCM to the top level now since it affects everything. Doing that is safe IMO. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts,

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson added a comment. > Improve text on existing QWidgets KCMs to conform to the HIG After this. > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG After this. > Port all QWidgets KCMs to QML I don't especially care, though it's often

D18419: Adjust some KCMs to implement new Appearance section layout

abetts added a comment. In D18419#400112 , @ngraham wrote: > That's good to hear! I'm glad we're on the same page. Let's make sure our plans in T8871: Systematic KCM reorganisation reflect the consensus of a

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. That's good to hear! I'm glad we're on the same page. Let's make sure our plans in T8871: Systematic KCM reorganisation reflect the consensus of a diverse set of opinions so we don't wind up needing to re-do it in the future.

D18419: Adjust some KCMs to implement new Appearance section layout

abetts added a comment. In D18419#399881 , @abetts wrote: > In D18419#397699 , @ngraham wrote: > > > I'm trying to get a sense of when we should do this. > > > > 1. Improve text on existing

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. Thanks @abetts, I appreciate the support, but I feel like it should not be for the reason that "the wave is to reorganize right now". This has nothing to to with popularity or momentum; it's because the reasons previously given for waiting wait are not valid. We

D18419: Adjust some KCMs to implement new Appearance section layout

abetts added a comment. In D18419#397699 , @ngraham wrote: > I'm trying to get a sense of when we should do this. > > 1. Improve text on existing QWidgets KCMs to conform to the HIG > 2. Re-arrange weird layouts for existing QWidgets KCMs

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. I'm trying to get a sense of when we should do this. 1. Improve text on existing QWidgets KCMs to conform to the HIG 2. Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG 3. Port all QWidgets KCMs to QML 4. Merge various KCMs together

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson added a comment. To clarify one thing, I didn't say "porting". The original task was to go through all of them unifying them, rethinking design and following Fabian's new HIG as well as making sure all options are in the right place, etc.. I personally don't particularly care

D18419: Adjust some KCMs to implement new Appearance section layout

abetts added a comment. I am not opposed to a reorg as long as it doesn't touch the KCMs, but be aware that you "might" have to reorg again as we port KCMs. So, do you prefer to do it, potentially twice, or just once? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. That's true, and we discussed this a lot in the VDG channel. The problem is that such a condition will in practice result in delaying this re-ogranization practically indefinitely. https://phabricator.kde.org/tag/plasma_kcm_redesign/ lists 42 KCMs that require

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We have all agreed before that we will not do any top-down shuffling until all the work updating KCMs bottom-up has been completed. It's documented in that linked

D18419: Adjust some KCMs to implement new Appearance section layout [1/3]

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is patch one out of three in support of the new Appearance section layout decided upon