D18519: [KColorSchemeEditor] Turn Save button into Save As

2019-05-09 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc63a8af3913: [KColorSchemeEditor] Turn Save button into Save As (authored by broulik). REPOSITORY R119 Plasma Deskt

D18519: [KColorSchemeEditor] Turn Save button into Save As

2019-01-27 Thread Andres Betts
abetts added a comment. I guess the way that the new theme is created through the ui is also something to consider. Maybe, let's think of a cleaner theme editing process and then the save button will be easier to understand? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabric

D18519: [KColorSchemeEditor] Turn Save button into Save As

2019-01-27 Thread Nathaniel Graham
ngraham added a comment. There's a somewhat awkward-feeling workflow here: 1. Edit a system color scheme 2. Click Save as... and save it as something else The config dialog remains open, but suddenly is showing the copy, not the original. However it does not show the Apply button.

D18519: [KColorSchemeEditor] Turn Save button into Save As

2019-01-25 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The button effectively saves the theme to be edited as a new file, so turn it into a "Save As