D18571: Add "apply on double-click" feature to most other recent ported KCMs

pino added a comment. In D18571#486708 , @ngraham wrote: > I think we need to implement this everywhere, or remove it from the Colors KCM. Indeed, this misfeature ought to be removed from the colors kcm for the reasons stated above.

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham abandoned this revision. ngraham added a comment. Per @mart's suggestion, I've implemented this in the base item itself so it doesn't need to be done individually for every KCM. See D22102 . REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ndavis added a comment. Agreed REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18571 To: ngraham, #vdg, #plasma, broulik, ndavis, mart Cc: mart, pino, davidedmundson, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. We remain in a situation where the Colors KCM has this feature, but none of the others do. I really like having it as a hidden accelerator there, and I miss it in the other KCMs. I think we need to implement this everywhere, or remove it from the Colors KCM. But

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. That's true, this would be new and unprecedented. But it that necessarily a bad thing? It's just a hidden accelerator, that's all. It feels very natural to me, and IMO it's far nicer than having to click the Apply button after selecting a new

D18571: Add "apply on double-click" feature to most other recent ported KCMs

mart added a comment. also, as the principle of the feature i agree with Pino I don't recall any non instant apply dialog anywhere which becomes magically instant apply on doubleclick REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18571 To: ngraham, #vdg,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. if this is going to be used, it should be in the base component (where you can safely assume that kcm.save will exist) and have it as mandatory for every kcm REPOSITORY R119

D18571: Add "apply on double-click" feature to most other recent ported KCMs

pino added a comment. -1 for this: - hidden feature - it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left free to play with options as they fit) - if an user

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. In D18571#401567 , @ndavis wrote: > I think having some hidden, non-essential features that speed things up here and there is not a bad idea. It's not an objective reason, but I think a lot of people enjoy finding

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ndavis added a comment. In D18571#401553 , @ngraham wrote: > One of the things I loved about macOS when I was a user was how many little hidden accelerators like this were sprinkled throughout the OS. You don't find them unless you go looking,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. One of the things I loved about macOS when I was a user was how many little hidden accelerators like this were sprinkled throughout the OS. You don't find them unless you go looking, but once you've found them, they're indispensable. There was a whole website I used

D18571: Add "apply on double-click" feature to most other recent ported KCMs

davidedmundson added a comment. We should definitely be consistent. So either this or removing it from colours. Personally I don't like it, we don't use double click anywhere else throughout all of Plasma, and given there's no visual hint upfront from a user POV it's random behaviour.

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 to this. It's nice when you already know what you're doing and want to change a setting quickly. REPOSITORY R119 Plasma Desktop BRANCH new-kcms-apply-on-double-click (branched from

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The new Colors KCM includes the "apply on double-click" feature requested in