D18621: Add again a button to manually scan for wireless networks

vpilo abandoned this revision. vpilo added a comment. I am abandoning this revision, since a button would be useless 95% of the time, thanks to NetworkManager. I'm submitting an automated retry mechanism. Later, I'd like to try adding some status icon showing when a new scan has been

D18621: Add again a button to manually scan for wireless networks

broulik added inline comments. INLINE COMMENTS > Toolbar.qml:116 > +id: wifiRefreshButton > +enabled: false > + I would do it declaratively: enabled: !coolDownTimer.running > Toolbar.qml:124 > + > +tooltip: i18ndc("plasma-nm", "button tooltip", "Scan for new >

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. If it wil be made configurable, you wouldn't be still able to use it, without depending on newer NM version. I don't see a big deal doing it this way: 1. Applet opened → request a scan 2. If the scan didn't go well, because we hit the 10s timout, go for

D18621: Add again a button to manually scan for wireless networks

vpilo added a comment. Let me be clear here - I don't really care about having this change merged, or having to rewrite it into something wholly different. I just want everyone to have their list of wifi networks to be up to date //when they need it//, that is, //when the nm applet is

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402832 , @davidedmundson wrote: > It's in 1.12. > > If that's not an option, it wouldn't be the end of the world to re-request a scan on a 2 second timer in case

D18621: Add again a button to manually scan for wireless networks

davidedmundson added a comment. It's in 1.12. If that's not an option, it wouldn't be the end of the world to re-request a scan on a 2 second timer in case Handler::replyFinished->Handler::RequestScan: It'll just retry until it passes then go back to the 15s. REPOSITORY R116 Plasma

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402768 , @davidedmundson wrote: > > I can find LastScan in the fd.o apidox, but not in NMQt... ?!? > > It doesn't seem to be there. So lets add it. It's not there because it's most likely one of

D18621: Add again a button to manually scan for wireless networks

ngraham added a comment. I'll note that keeping the user feeling in control is one of the bullet points on the homepage of our HIG : > //Always in control.// - It should always be clear what can be done, what is currently happening, and what has just

D18621: Add again a button to manually scan for wireless networks

davidedmundson added a comment. > I can find LastScan in the fd.o apidox, but not in NMQt... ?!? It doesn't seem to be there. So lets add it. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18621 To: vpilo, #vdg, #plasma, jgrulich,

D18621: Add again a button to manually scan for wireless networks

ngraham added a comment. Again, I think this is a "the user doesn't feel in control" issue. If a feature of the software cannot automatically anticipate and meet user needs with 100% reliability, then the user must be provided with a method to self-serve for the cases where the software 's

D18621: Add again a button to manually scan for wireless networks

vpilo added a comment. In D18621#402717 , @jgrulich wrote: > In D18621#402712 , @vpilo wrote: > > > But there are legit cases where this timeout is way too long for no reason. > > > > If you

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402712 , @vpilo wrote: > But there are legit cases where this timeout is way too long for no reason. > > If you close the popup and reopen it before the NM timeout expires, then the first request will

D18621: Add again a button to manually scan for wireless networks

vpilo added a comment. Herald added 1 blocking reviewer(s): jgrulich. But there are legit cases where this timeout is way too long for no reason. If you close the popup and reopen it before the NM timeout expires, then the first request will fail, no attempt will be made at redoing the

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402605 , @alexeymin wrote: > In D18621#402558 , @ngraham wrote: > > > In my opinion, this sort of thing is a "help the user feel in control" issue. > > >

D18621: Add again a button to manually scan for wireless networks

vpilo updated this revision to Diff 50583. vpilo added a comment. - Review comments: change button tooltip REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18621?vs=50566=50583 BRANCH vpilo/refreshButton (branched from master)

D18621: Add again a button to manually scan for wireless networks

alexeymin added a comment. In D18621#402558 , @ngraham wrote: > In my opinion, this sort of thing is a "help the user feel in control" issue. +1, it would be cool to have a button to scan for wireless networks. Today I tried to connect

D18621: Add again a button to manually scan for wireless networks

vpilo added a comment. In D18621#402558 , @ngraham wrote: > In my opinion, this sort of thing is a "help the user feel in control" issue. We had the same sort of conversations in Discover back when it didn't have a manual "refresh updates"

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402559 , @jgrulich wrote: > I'm wrong, it actually doesn't perform scanning when the applet is opened. It should maybe be doing that, do initial scan on applet popup and then every 15 seconds only if you keep

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. I'm wrong, it actually doesn't perform scanning when the applet is opened. It should maybe be doing that, do initial scan on applet popup and then every 15 seconds only if you keep it opened. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18621: Add again a button to manually scan for wireless networks

ngraham added a comment. In D18621#402540 , @jgrulich wrote: > I don't think this should be added again, there is no reason to. Plasma-nm will do an initial scan once the applet is opened so you get the new networks immediately. This has been

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. I don't think this should be added again, there is no reason to. Plasma-nm will do an initial scan once the applet is opened so you get the new networks immediately. This has been discussed with NetworkManager developers and everyone has to do now periodic scanning

D18621: Add again a button to manually scan for wireless networks

ngraham added a comment. +1, this annoys me too. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18621 To: vpilo, #vdg, #plasma, jgrulich, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18621: Add again a button to manually scan for wireless networks

ngraham added inline comments. INLINE COMMENTS > Toolbar.qml:124 > + > +tooltip: i18n("Rescan wireless networks") > +iconSource: "view-refresh" How about "Scan for new wireless networks"? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18621: Add again a button to manually scan for wireless networks

vpilo created this revision. vpilo added reviewers: VDG, Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY The current 15 seconds timeout is really annoyingly long. NetworkManager