D18861: Improve the Fonts KCM UI

davidedmundson accepted this revision. davidedmundson added a comment. > Perhaps "Modernize" would be a more specific word than "Improve"? Not really. There's nothing "modern" about putting an icon on a button. adding "UI" helps clarify it's not behavioural changes. That'll do.

D18861: Improve the Fonts KCM UI

ngraham added a comment. Perhaps "Modernize" would be a more specific word than "Improve"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma,

D18861: Improve the Fonts KCM UI

GB_2 added a comment. In D18861#408459 , @davidedmundson wrote: > Please use more descriptive messages than "Improve the blahblah". > Practically every single commit aims to improve the product. I added the word UI, what do you

D18861: Improve the Fonts KCM UI

davidedmundson added a comment. Please use more descriptive messages than "Improve the blahblah". Practically every single commit aims to improve the product. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc:

D18861: Improve the Fonts KCM UI

ngraham added a comment. The other ordering is more English-like, but your suggestion would probably be fine too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty, plasma-devel, #vdg,

D18861: Improve the Fonts KCM UI

GB_2 added a comment. What about `Noto Sans 10pt`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18861: Improve the Fonts KCM UI

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. All right, let's do that. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham,

D18861: Improve the Fonts KCM UI

ndavis added a comment. In D18861#408286 , @ngraham wrote: > Personally my preference would be for the strings to be like this: `10 pt Noto Sans` That would be fine too since it reads like English. The `|` character makes it seem like

D18861: Improve the Fonts KCM UI

ngraham added a comment. Personally my preference would be for the strings to be like this: `10 pt Noto Sans` REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty,

D18861: Improve the Fonts KCM UI

ndavis added a comment. I don't like the look of the `|` character between the font name and the font size. I think the existing "Noto Sans 10" format looked better, but I'm not going to formally request changes. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D18861: Improve the Fonts KCM UI

GB_2 updated this revision to Diff 51213. GB_2 added a comment. Change "Force fonts DPI" checkbox text to "Force font DPI" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18861?vs=51211=51213 BRANCH master REVISION DETAIL

D18861: Improve the Fonts KCM UI

rooty added a comment. nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg Cc: rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. No suggestions for improvement! I guess because this has already been discussed for weeks in the IRC channel. :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D18861: Improve the Fonts KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to

D18861: Improve the Fonts KCM UI

rooty accepted this revision. rooty added a comment. yeah we've been discussing this for weeks you've got my vote :D REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ngraham, rooty,