D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

abetts added a comment. In D18893#412372 , @rooty wrote: > Hey guys so I opened up another diff to deal with the icons specifically: D19020 > > > For this image with the dots and type, shouldn't that be

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. Hey guys so I opened up another diff to deal with the icons specifically: D19020 > For this image with the dots and type, shouldn't that be centered and not touch the edge of the circle? That works too, but the idea here

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ccefa20ae859: [sddm-theme] Add buttons to username prompt to make it a full-fledged login… (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

abetts added a comment. In D18893#412025 , @rooty wrote: > Thanks for accepting the patch! > Should I land this and deal with the icons in another diff? Because this is in "plasma-workspace" and the icons are in "plasma-framework"? > >

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham accepted this revision. ngraham added a comment. Land this now, then let's do the icons in another patch. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D18893 REVISION DETAIL https://phabricator.kde.org/D18893 To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham Cc:

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. Thanks for accepting the patch! Should I land this and deal with the icons in another diff? Because this is in "plasma-workspace" and the icons are in "plasma-framework"? Then again, I might have to change the code here (the new icons have different labels).

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty updated this revision to Diff 51667. rooty added a comment. Add visible: !inputPanel.keyboardActive REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18893?vs=51303=51667 BRANCH arcpatch-D18893 REVISION DETAIL

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. In D18893#409907 , @davidedmundson wrote: > From my POV, +1 too. Good point! I'll just add it REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18893 To: rooty, #vdg, #plasma, filipf Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen,

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

davidedmundson added a comment. From my POV, +1 too. INLINE COMMENTS > Main.qml:373 > +text: > i18nd("plasma_lookandfeel_org.kde.lookandfeel","List Users") > onClicked: mainStack.pop() > } should this also have visible:

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham added a comment. +1 on the concept. Adding here my comments in the #VDG channel regarding the icons: - For the "Type User" icon, I liked the one that was dots/asterisks with an I-Beam cursor at the end. - For the "List Users" icon, my

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. I couldn't really sleep last night so i made this one too F6606942: image.png Any and all input regarding the design of the icons is appreciated :D REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. In D18893#409220 , @ngraham wrote: > Yeah, like a line-art representation of the horizontal switcher, and a line-art representation of a username/password prompt. How's this for the switcher? F6606370:

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham added a comment. Yeah, like a line-art representation of the horizontal switcher, and a line-art representation of a username/password prompt. REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. In D18893#409130 , @ngraham wrote: > If we do this, then "List Users" and "Type User" will both be using the same icons. Feels like we should use more appropriate ones that visually suggest what the page it will take you

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham added a comment. If we do this, then "List Users" and "Type User" will both be using the same icons. Feels like we should use more appropriate ones that visually suggest what the page it will take you to actually looks like. REPOSITORY R120 Plasma Workspace BRANCH

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18893 To: rooty, #vdg, #plasma, filipf Cc:

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds the buttons Suspend, Restart, Shut Down to the username prompt screen that appears once the Type User button is