D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-03-11 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d769b7aa8838: [Task Manager] Fix virtual desktops subtext on task tooltip (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-02-23 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > Task.qml:370 > toolTipDelegate.virtualDesktopParent = > Qt.binding(function() { > -return model.VirtualDesktop != undefined ? > model.VirtualDesktop : 0; > +return

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-02-23 Thread Christian
Fuchs added a comment. One minor nitpick: if it is on all virtual desktops there is no text shown, maybe some "is on all virtual desktops" or so would be nice, for consistency. But it might entirely be that it didn't do that before either, at least the code looks like it. Also this

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-02-23 Thread Christian
Fuchs added a comment. Yep, that works here, even with groups spanning multiple desktops. Thanks for the quick fix! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19257 To: hein, #plasma Cc: Fuchs, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-02-23 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:404706 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D19257 AFFECTED FILES