D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-03-01 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ff0a0e30a28a: [ConfigCategoryDelegate] Add horizontal padding to the label (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-03-01 Thread Nathaniel Graham
ngraham added a comment. In that case, see https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R119 Plasma Desktop BRANCH config-category-label-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D19275 To:

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-03-01 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. You can merge to 5.15 if you want. REPOSITORY R119 Plasma Desktop BRANCH config-category-label-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham,

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-03-01 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH config-category-label-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-03-01 Thread Nathaniel Graham
ngraham added a comment. I'd say go for it. :) REPOSITORY R119 Plasma Desktop BRANCH config-category-label-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-03-01 Thread Filip Fila
filipf added a comment. Any more thoughts on this? REPOSITORY R119 Plasma Desktop BRANCH config-category-label-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-02-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Conceptually sound. I'd say this even is a bugfix that can land on the `Plasma/5.15` branch, if the #plasma folks agree. See

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-02-24 Thread Krešimir Čohar
rooty added a comment. you got my vote, i think this looks a lot less stuck-on REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

2019-02-24 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds horizontal padding to the category configuration delegate so that the label does not look like it is glued to the