D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread Nathaniel Graham
ngraham added a comment. In D19373#425115 , @davidedmundson wrote: > I don't think we can ship anything without a config, if a user can configure login background and desktop background, showing a "random" wallpaper in the middle is bound to

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread Andres Betts
abetts added a comment. +1 on looks REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19373 To: ngraham, #vdg, #plasma, rooty Cc: abetts, davidedmundson, filipf, rooty, plasma-devel, jraleigh,

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread Krešimir Čohar
rooty added a comment. Wait so the flicker's fixable? REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19373 To: ngraham, #vdg, #plasma, rooty Cc: davidedmundson, filipf, rooty, plasma-devel,

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread David Edmundson
davidedmundson added a comment. The original rationale of the time of having the black background was to hide the flickering blank framebuffer as we switch from SDDM to the login - and we're autologigng in we're coming from a black background too. From a tech POV I like that because loading

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-04 Thread Krešimir Čohar
rooty added a comment. P.S. I've been using this for a couple of days now, and I really like it. Another idea (for another diff) - we could also ditch the "Plasma made by KDE" label and logo in the bottom right corner seeing as we already have the Plasma logo above the spinning circle? It

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Krešimir Čohar
rooty added a comment. In D19373#420786 , @filipf wrote: > ^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Filip Fila
filipf added a comment. ^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that implementing it here would be rushing things REPOSITORY R120 Plasma Workspace

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Krešimir Čohar
rooty added a comment. I don't know... if we made the splash screen use the same image as the login screen, it would become an extension of the login screen. Because otherwise, for a user that's using a third party wallpaper for the breeze sddm theme, you've got (1) one wallpaper for

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Nathaniel Graham
ngraham added a comment. In D19373#420768 , @rooty wrote: > Hold on, could we? > If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze > Could we make the sddm theme and this splash screen use that same file?

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Filip Fila
filipf added a comment. Finally! Now let's just get it to work. INLINE COMMENTS > Splash.qml:28 > +// ${CMAKE_INSTALL_PREFIX}/${WALLPAPER_INSTALL_DIR > +source: "/usr/share/wallpapers/Next/contents/images/3200x2000.png" > +fillMode: Image.PreserveAspectCrop This will get removed

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Krešimir Čohar
rooty added a comment. Hold on, could we? If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze Could we make the sddm theme and this splashscreen use that same file? REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Krešimir Čohar
rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Wow that's fancy. +1 I only wish we could also change the Splash Screen background the same way we can change the sddm theme background. Or better yet, have matching

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-02-26 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current Breeze splash screen is rather visually incongruous with what comes