D19467: [colors-kcm] Fix blurry previews

filipf added a comment. In D19467#424552 , @davidedmundson wrote: > @filipf It's time for to learn the magic of gammaray ! > > gammaray kcmshell5 colors > > and go to the quick scenes tabs. It might tell you something useful.

D19467: [colors-kcm] Fix blurry previews

davidedmundson added a comment. @filipf It's time for to learn the magic of gammaray ! gammaray kcmshell5 colors and go to the quick scenes tabs. It might tell you something useful. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf,

D19467: [colors-kcm] Fix blurry previews

ngraham added a comment. Make its flickable have `pixelAligned: true`, maybe? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: ngraham, abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2,

D19467: [colors-kcm] Fix blurry previews

filipf added a comment. Actually now that I take a closer look all of our previews are blurry. It's because there's text in the colors KCM that it becomes obvious. Compare the desktop theme KCM preview in its original state: F6656755: Screenshot_20190304_173527.png

D19467: [colors-kcm] Fix blurry previews

davidedmundson added a comment. Why does this make a difference to things being blurry? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2,

D19467: [colors-kcm] Fix blurry previews

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19467: [colors-kcm] Fix blurry previews

broulik added a comment. Looks like KCM GridView should round the cell sizes to avoid non-integer pixel alignment REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: davidedmundson, rooty, plasma-devel,

D19467: [colors-kcm] Fix blurry previews

filipf updated this revision to Diff 52986. filipf added a comment. don't round numbers unnecessarily REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19467?vs=52951=52986 BRANCH fix-blurry-previews (branched from master) REVISION DETAIL

D19467: [colors-kcm] Fix blurry previews

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't understand Kirigami.gridUnit is a whole number 13 is a a whole number Why does Math.round fix anything? REPOSITORY R119 Plasma Desktop

D19467: [colors-kcm] Fix blurry previews

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Looks good to me. You might want to wait for someone else's say-so too tho REPOSITORY R119 Plasma Desktop BRANCH fix-blurry-previews (branched from master) REVISION DETAIL

D19467: [colors-kcm] Fix blurry previews

filipf added a comment. If this is too small the next number that doesn't result in blurry previews is multiplying with 16: F6648523: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf,

D19467: [colors-kcm] Fix blurry previews

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY With the current settings text in color scheme previews is blurry. This patch aims to fix that and as a side-effect also creates